-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Unskip alerts cell actions tests #174096
[Security Solution] Unskip alerts cell actions tests #174096
Conversation
ff851cf
to
bb24efc
Compare
/ci |
df1ad24
to
549e232
Compare
549e232
to
93a5f2f
Compare
/ci |
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice cleanup! Thanks for merging some tests. I left a few minor comments, but overall looks good!
...k/test/security_solution_cypress/cypress/e2e/investigations/alerts/alerts_cell_actions.cy.ts
Outdated
Show resolved
Hide resolved
...k/test/security_solution_cypress/cypress/e2e/investigations/alerts/alerts_cell_actions.cy.ts
Outdated
Show resolved
Hide resolved
...k/test/security_solution_cypress/cypress/e2e/investigations/alerts/alerts_cell_actions.cy.ts
Show resolved
Hide resolved
...k/test/security_solution_cypress/cypress/e2e/investigations/alerts/alerts_cell_actions.cy.ts
Outdated
Show resolved
Hide resolved
...k/test/security_solution_cypress/cypress/e2e/investigations/alerts/alerts_cell_actions.cy.ts
Outdated
Show resolved
Hide resolved
3812cb1
to
645fdcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing these!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the cleanup @lgestc, it looks great!
Don't forget to undo the changes to the package.json
before merging 😄
2b44f08
to
a73181d
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
## Summary This PR unskips alerts cell actions tests, skipped here: elastic#172233 elastic#172231 elastic#173442 elastic#172230 elastic#172232 It also: - combines a few cases and beforeEach steps. - removes some of the force clicks from the click action task. FTR build: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4783
## Summary This PR unskips alerts cell actions tests, skipped here: elastic#172233 elastic#172231 elastic#173442 elastic#172230 elastic#172232 It also: - combines a few cases and beforeEach steps. - removes some of the force clicks from the click action task. FTR build: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4783
Summary
This PR unskips alerts cell actions tests, skipped here:
#172233
#172231
#173442
#172230
#172232
It also:
FTR build: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4783