Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Unskip alerts cell actions tests #174096

Merged

Conversation

lgestc
Copy link
Contributor

@lgestc lgestc commented Jan 2, 2024

Summary

This PR unskips alerts cell actions tests, skipped here:

#172233
#172231
#173442
#172230
#172232

It also:

  • combines a few cases and beforeEach steps.
  • removes some of the force clicks from the click action task.

FTR build: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4783

@lgestc lgestc force-pushed the unskip_alerts_cell_actions_tests branch 5 times, most recently from ff851cf to bb24efc Compare January 3, 2024 15:04
@lgestc
Copy link
Contributor Author

lgestc commented Jan 3, 2024

/ci

@lgestc lgestc added Team:Threat Hunting:Investigations Security Solution Investigations Team release_note:skip Skip the PR/issue when compiling release notes 8.13 candidate labels Jan 3, 2024
@lgestc lgestc force-pushed the unskip_alerts_cell_actions_tests branch 2 times, most recently from df1ad24 to 549e232 Compare January 3, 2024 16:39
@lgestc lgestc force-pushed the unskip_alerts_cell_actions_tests branch from 549e232 to 93a5f2f Compare January 3, 2024 19:22
@lgestc
Copy link
Contributor Author

lgestc commented Jan 3, 2024

/ci

@lgestc lgestc marked this pull request as ready for review January 4, 2024 07:32
@lgestc lgestc requested review from a team as code owners January 4, 2024 07:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup! Thanks for merging some tests. I left a few minor comments, but overall looks good!

@lgestc lgestc requested a review from PhilippeOberti January 8, 2024 13:59
@lgestc lgestc force-pushed the unskip_alerts_cell_actions_tests branch from 3812cb1 to 645fdcd Compare January 8, 2024 14:00
Copy link
Contributor

@janmonschke janmonschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these!

Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup @lgestc, it looks great!

Don't forget to undo the changes to the package.json before merging 😄

@lgestc lgestc force-pushed the unskip_alerts_cell_actions_tests branch from 2b44f08 to a73181d Compare January 8, 2024 16:20
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #10 / FilesUtilityBar renders correctly
  • [job] [logs] Jest Tests #10 / FilesUtilityBar search text passed correctly to callback

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@PhilippeOberti PhilippeOberti merged commit a48eb82 into elastic:main Jan 8, 2024
38 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Jan 8, 2024
This was referenced Jan 8, 2024
nreese pushed a commit to nreese/kibana that referenced this pull request Jan 10, 2024
## Summary

This PR unskips alerts cell actions tests, skipped here:

elastic#172233
elastic#172231
elastic#173442
elastic#172230
elastic#172232

It also:
- combines a few cases and beforeEach steps.
- removes some of the force clicks from the click action task.

FTR build:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4783
delanni pushed a commit to delanni/kibana that referenced this pull request Jan 11, 2024
## Summary

This PR unskips alerts cell actions tests, skipped here:

elastic#172233
elastic#172231
elastic#173442
elastic#172230
elastic#172232

It also:
- combines a few cases and beforeEach steps.
- removes some of the force clicks from the click action task.

FTR build:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.13 candidate backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants