[EDR Workflows][Osquery] Missing timeout value when running query from query history #174088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szwarckonrad
added
bug
|
/ci |
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
szwarckonrad
changed the title
# Conflicts: # x-pack/plugins/osquery/cypress/tasks/saved_queries.ts
patrykkopycinski
approved these changes
Jan 22, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
tomsonpl
approved these changes
Jan 22, 2024
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
szwarckonrad
added a commit
that referenced
this pull request
Jan 22, 2024
…ery from query history (#174088) (#175217) # Backport This will backport the following commits from `main` to `8.12`: - [[EDR Workflows][Osquery] Missing timeout value when running query from query history (#174088)](#174088) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Konrad Szwarc","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-22T14:17:12Z","message":"[EDR Workflows][Osquery] Missing timeout value when running query from query history (#174088)\n\nhttps://github.com//issues/174082\r\n\r\nFixed bug with `timeout` field not being properly passed from Query\r\nHistory list to query form.\r\nAdded test coverage.\r\n \r\n\r\nhttps://github.com/elastic/kibana/assets/29123534/48862490-d308-47c6-bdc1-d2c10ec8533d","sha":"0aadaa9d7cdc8c1b1f2c49731169b767176b9377","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Defend Workflows","ci:all-cypress-suites","Osquery","v8.12.1","v8.13.0"],"number":174088,"url":"https://github.com/elastic/kibana/pull/174088","mergeCommit":{"message":"[EDR Workflows][Osquery] Missing timeout value when running query from query history (#174088)\n\nhttps://github.com//issues/174082\r\n\r\nFixed bug with `timeout` field not being properly passed from Query\r\nHistory list to query form.\r\nAdded test coverage.\r\n \r\n\r\nhttps://github.com/elastic/kibana/assets/29123534/48862490-d308-47c6-bdc1-d2c10ec8533d","sha":"0aadaa9d7cdc8c1b1f2c49731169b767176b9377"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174088","number":174088,"mergeCommit":{"message":"[EDR Workflows][Osquery] Missing timeout value when running query from query history (#174088)\n\nhttps://github.com//issues/174082\r\n\r\nFixed bug with `timeout` field not being properly passed from Query\r\nHistory list to query form.\r\nAdded test coverage.\r\n \r\n\r\nhttps://github.com/elastic/kibana/assets/29123534/48862490-d308-47c6-bdc1-d2c10ec8533d","sha":"0aadaa9d7cdc8c1b1f2c49731169b767176b9377"}}]}] BACKPORT-->
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…m query history (elastic#174088) elastic#174082 Fixed bug with `timeout` field not being properly passed from Query History list to query form. Added test coverage. https://github.com/elastic/kibana/assets/29123534/48862490-d308-47c6-bdc1-d2c10ec8533d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#174082
Fixed bug with
timeoutfield not being properly passed from Query History list to query form.Added test coverage.
Screen.Recording.2024-01-02.at.15.24.26.mov