[OBS-UX-MNGMT] - Add P95, P99, and RATE Aggs to the Custom Threshold rule #173728

fkanout · 2023-12-20T11:39:18Z

Summary

Fixes #172945 by adding P95, P99, and RATE Aggs to the Custom Threshold rule

elasticmachine · 2023-12-20T11:39:24Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

apmmachine · 2023-12-20T11:39:32Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
/oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

…hold-rule

maryam-saeidi

I tried to create a rule and I got this error:

Looking at the code, I don't see adding these new aggregations to the executor.

@simianhacker I remember you were talking about some minor differences between these aggregations and the rest. Would you please share those differences to ensure we check them during the PR review?

It would be good to add an API integration test for one of these integration (Maybe the one that has more differences based on Chris's input)

x-pack/plugins/observability/public/components/custom_threshold/components/expression_row.tsx

fkanout

Checking the commits, it seems there is a divergence. Woking on fixing it

…hold-rule

fkanout · 2023-12-28T16:38:27Z

@elasticmachine merge upstream

…hold-rule

fkanout · 2023-12-28T16:40:31Z

I tried to create a rule and I got this error:

@maryam-saeidi, the allowed Aggs were hard coded. Fixed here https://github.com/elastic/kibana/pull/173728/files#diff-2c2365096901ec4d3f525f2de7671eee30ae3e61da3925c6c94d257b006ea71cR88

…-fix'

fkanout · 2024-01-02T10:15:44Z

@elasticmachine merge upstream

…hold-rule

.../observability/public/components/custom_threshold/components/preview_chart/preview_chart.tsx

…centile-aggs-custom-threshold-rule

.../observability/public/components/custom_threshold/components/rule_condition_chart/helpers.ts

maryam-saeidi · 2024-02-05T16:32:56Z

.../observability/public/components/custom_threshold/components/rule_condition_chart/helpers.ts

+export const lensFieldFormatter = (
+  metrics: CustomThresholdExpressionMetric[]
+): typeof LensFieldFormat[keyof typeof LensFieldFormat] => {
+  if (metrics.length < 1 || !metrics[0].field) return LensFieldFormat.NUMBER;


Does it mean we will use the first metric's unit for the whole equation? Does it work for all the scenarios? (Not sure how we can check this.)

The safer option would be to only format when we have one metric but I cannot think of a scenario that this would create an issue. What do you think @simianhacker @maciejforcone @paulb-elastic?

@maryam-saeidi I agree. We can go further. Even if we have more than one metric, we check if ALL have the same field type and then apply the format; otherwise, there is no format.

I agree, if all the fields have the same formatter, then we format, otherwise leave it raw.

x-pack/plugins/observability/server/lib/rules/custom_threshold/lib/format_alert_result.ts

x-pack/test/alerting_api_integration/observability/custom_threshold_rule/rate_bytes_fired.ts

maryam-saeidi · 2024-02-06T09:23:16Z

x-pack/plugins/observability/server/lib/rules/custom_threshold/lib/metric_query.ts

-  start: moment(timeframe.end).subtract(metricParams.timeSize, metricParams.timeUnit).valueOf(),
-});
+) => {
+  const isRateAgg = metricParams.metrics.some((metric) => metric.aggType === Aggregators.RATE);


Difference in seconds is related to lastPeriod (more info)

…hold-rule

kibana-ci · 2024-02-07T11:31:02Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 4348f58

Failed CI Steps

FTR Configs #25

Test Failures

[job] [logs] FTR Configs #25 / APM API tests correlations/latency.spec.ts trial 8.0.0 "before all" hook: runBefore in "8.0.0"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`observability`	595	596	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`observability`	634.7KB	635.6KB	+957.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`observability`	101.9KB	102.0KB	+83.0B

History

💔 Build #191711 failed c754e37
💔 Build #191660 failed 66a9516
💔 Build #191612 failed b01e1ad
💛 Build #191328 was flaky 162a4a7
💔 Build #191323 failed eb9e5c3
💔 Build #191313 failed e2f640a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @fkanout

…rule (elastic#173728) ## Summary Fixes elastic#172945 by adding P95, P99, and RATE Aggs to the Custom Threshold rule <img width="575" alt="Screenshot 2023-12-20 at 12 31 50" src="https://github.com/elastic/kibana/assets/6838659/fd9f33fc-97c5-4cf8-b15e-3134048c861a"> <img width="565" alt="Screenshot 2023-12-20 at 12 31 57" src="https://github.com/elastic/kibana/assets/6838659/56047c84-a6e5-4a8a-a05f-b6c1358a7297"> <img width="601" alt="Screenshot 2023-12-20 at 12 36 16" src="https://github.com/elastic/kibana/assets/6838659/af7c291d-320f-4cb1-b62f-46e29f596bcd">

fkanout added 2 commits December 20, 2023 12:31

Add P99, P95 and RATE to custom threshold rule

9876546

Add rate option to the agg list

0b767ee

fkanout requested a review from a team as a code owner December 20, 2023 11:39

botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Dec 20, 2023

fkanout added Feature:Alerting Feature: Custom threshold Observability custom threshold rule type v8.13.0 labels Dec 20, 2023

fkanout self-assigned this Dec 20, 2023

fkanout added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Dec 20, 2023

fkanout and others added 5 commits December 20, 2023 12:40

Add i18n message

27d669b

Merge branch 'main' into 172945-add-rate-percentile-aggs-custom-thres…

7dbdc97

…hold-rule

Update import

f7fac1a

Merge branch 'main' into 172945-add-rate-percentile-aggs-custom-thres…

ceb64b1

…hold-rule

Merge branch 'main' into 172945-add-rate-percentile-aggs-custom-thres…

c3f691a

…hold-rule

maryam-saeidi reviewed Dec 22, 2023

View reviewed changes

x-pack/plugins/observability/public/components/custom_threshold/components/expression_row.tsx Outdated Show resolved Hide resolved

fkanout commented Dec 26, 2023

View reviewed changes

fkanout and others added 6 commits December 27, 2023 14:29

Recover commit P99 and P95

ef0304a

Add rate Agg

4541dd4

Merge branch 'main' into 172945-add-rate-percentile-aggs-custom-thres…

a62ab17

…hold-rule

Update name

87404bb

Update reason messages for the new Aggs P95 P99 and Rate

d0980ee

Add integration tests

c6f499d

Merge branch 'main' into 172945-add-rate-percentile-aggs-custom-thres…

d3b3eef

…hold-rule

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

3ad7d45

…-fix'

fkanout and others added 2 commits January 30, 2024 11:10

remove unwanted comment

39e9301

Merge branch 'main' into 172945-add-rate-percentile-aggs-custom-thres…

cddb3d8

…hold-rule

maryam-saeidi reviewed Jan 30, 2024

View reviewed changes

.../observability/public/components/custom_threshold/components/preview_chart/preview_chart.tsx Outdated Show resolved Hide resolved

fkanout added 7 commits February 2, 2024 13:16

Format reason message and add events as a unit

76c7b6b

Merge remote-tracking branch 'upstream/main' into 172945-add-rate-per…

de1df1a

…centile-aggs-custom-threshold-rule

Update events as units

6a74f8f

Fix types after merge main

e2f640a

Fix import

d2f26b3

Fix tests

eb9e5c3

Fix import

162a4a7

fkanout requested a review from maryam-saeidi February 5, 2024 14:03

maryam-saeidi reviewed Feb 6, 2024

View reviewed changes

fkanout added 4 commits February 6, 2024 13:14

Code review

dbeee32

code review and fix reason message

388e8cf

remove bits format

a870f8a

remove bits format

b01e1ad

fkanout requested a review from maryam-saeidi February 6, 2024 13:34

maryam-saeidi approved these changes Feb 6, 2024

View reviewed changes

fkanout enabled auto-merge (squash) February 6, 2024 13:45

fkanout and others added 3 commits February 6, 2024 16:42

fix tests

66a9516

Fix tests

c754e37

Merge branch 'main' into 172945-add-rate-percentile-aggs-custom-thres…

4348f58

…hold-rule

fkanout merged commit ed2e3f8 into elastic:main Feb 7, 2024
18 checks passed

elasticmachine unassigned fkanout Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[OBS-UX-MNGMT] - Add P95, P99, and RATE Aggs to the Custom Threshold rule #173728

[OBS-UX-MNGMT] - Add P95, P99, and RATE Aggs to the Custom Threshold rule #173728

fkanout commented Dec 20, 2023

elasticmachine commented Dec 20, 2023

apmmachine commented Dec 20, 2023

maryam-saeidi left a comment •

edited

Loading

fkanout left a comment

fkanout commented Dec 28, 2023

fkanout commented Dec 28, 2023

fkanout commented Jan 2, 2024

maryam-saeidi Feb 5, 2024

fkanout Feb 6, 2024 •

edited

Loading

simianhacker Feb 6, 2024

maryam-saeidi Feb 6, 2024

kibana-ci commented Feb 7, 2024

[OBS-UX-MNGMT] - Add P95, P99, and RATE Aggs to the Custom Threshold rule #173728

[OBS-UX-MNGMT] - Add P95, P99, and RATE Aggs to the Custom Threshold rule #173728

Conversation

fkanout commented Dec 20, 2023

Summary

elasticmachine commented Dec 20, 2023

apmmachine commented Dec 20, 2023

🤖 GitHub comments

maryam-saeidi left a comment • edited Loading

Choose a reason for hiding this comment

fkanout left a comment

Choose a reason for hiding this comment

fkanout commented Dec 28, 2023

fkanout commented Dec 28, 2023

fkanout commented Jan 2, 2024

maryam-saeidi Feb 5, 2024

Choose a reason for hiding this comment

fkanout Feb 6, 2024 • edited Loading

Choose a reason for hiding this comment

simianhacker Feb 6, 2024

Choose a reason for hiding this comment

maryam-saeidi Feb 6, 2024

Choose a reason for hiding this comment

kibana-ci commented Feb 7, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

maryam-saeidi left a comment •

edited

Loading

fkanout Feb 6, 2024 •

edited

Loading