Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnifiedFieldList] Show drag handle on item hover #173673

Merged
merged 6 commits into from
Jan 3, 2024
Merged

[UnifiedFieldList] Show drag handle on item hover #173673

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d6ec83d
[UnifiedFieldList] Show drag handle on hover
jughosta Dec 19, 2023
0c42380
Merge branch 'main' into 168856-field-list-drag-handle-v2
jughosta Dec 19, 2023
92f63b5
Merge branch 'main' into 168856-field-list-drag-handle-v2
kibanamachine Dec 19, 2023
2940b6b
Merge branch 'main' into 168856-field-list-drag-handle-v2
jughosta Dec 22, 2023
aa1b869
Merge branch 'main' into 168856-field-list-drag-handle-v2
jughosta Jan 2, 2024
728fa09
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
193 changes: 138 additions & 55 deletions ...field-list/src/components/field_item_button/__snapshots__/field_item_button.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

35 changes: 35 additions & 0 deletions packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,38 @@
background: lightOrDarkTheme(transparentize($euiColorMediumShade, .9), $euiColorEmptyShade);
color: $euiColorDarkShade;
}

.unifiedFieldListItemButton__fieldIconContainer {
position: relative;
}

.unifiedFieldListItemButton__fieldIcon {
transition: opacity $euiAnimSpeedNormal ease-in-out;
}

.unifiedFieldListItemButton__fieldIconDrag {
visibility: hidden;
position: absolute;
top: 0;
left: 0;
transition: opacity $euiAnimSpeedNormal ease-in-out;
}

// A drag handle will appear only on item hover/focus
.unifiedFieldListItemButton--withDragIcon {
.unifiedFieldListItemButton__fieldIconDrag {
visibility: visible;
opacity: 0;
}

&:hover,
&[class*='-isActive'],
.domDragDrop__keyboardHandler:focus + & {
.unifiedFieldListItemButton__fieldIcon {
opacity: 0;
}
.unifiedFieldListItemButton__fieldIconDrag {
opacity: 1;
}
}
}
6 changes: 3 additions & 3 deletions packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const bytesField = dataView.getFieldByName('bytes')!;
const scriptedField = dataView.getFieldByName('script date')!;
const conflictField = dataView.getFieldByName('custom_user_field')!;

describe('UnifiedFieldList <FieldItemButton />', () => {
describe('UnifiedFieldList FieldItemButton', () => {
test('renders properly', () => {
const component = shallow(
<FieldItemButton
Expand Down Expand Up @@ -115,13 +115,13 @@ describe('UnifiedFieldList <FieldItemButton />', () => {
expect(component).toMatchSnapshot();
});

test('renders properly with a drag handle', () => {
test('renders properly with a drag icon', () => {
const component = shallow(
<FieldItemButton
size="xs"
className="custom"
dataTestSubj="test-subj"
dragHandle={<span>dragHandle</span>}
withDragIcon={true}
field={bytesField}
fieldSearchHighlight={undefined}
isEmpty={false}
Expand Down
Loading