[Maps] Store map saved objects state in unmapped fields #173528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickpeihl
added
the
Team:Presentation
nickpeihl
changed the title
nickpeihl
changed the title
nickpeihl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a PoC/WIP to resolve #167834 using
modelVersionsand backwards compatibility. This was a SpaceTime project and remains unfinished.The maps saved objects are migrated so that the
mapStateJSON,uiStateJSON, andlayerListJSONare de-stringified and stored as native objects in new unmapped fields (mapState,uiState, andlayerList). The existing*JSONfields remain in the saved object, but could be deprecated/removed in a later modelVersion.Unfortunately, I did not have time to work on embeddable migrations. So by-value map embeddables in Dashboards are not de-stringified. Updating the embeddable migrations to support zero-downtime migrations is a larger effort that may need to be implemented separately.