Change POST to PUT and _security to security for API example #173453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview: |
vadimkibana
approved these changes
Jan 2, 2024
|
@elasticmachine merge upstream |
Terilia
added
release_note:skip
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 3, 2024
…#173453) ## Summary Just a small Doc Update. In the first example a POST was used and towards a non existing handle (`_security` instead of `security`) In the basic license example posted below this one, this is already correct. ### Checklist All checked - none applied. (Though first PR in this repository, I am sorry if any mistakes were made. If so - please point them out, will do better next time 😅 ) --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 96ada94)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 3, 2024
…173453) (#174179) # Backport This will backport the following commits from `main` to `8.12`: - [Change POST to PUT and _security to security for API example (#173453)](#173453) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alex S","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-03T14:07:21Z","message":"Change POST to PUT and _security to security for API example (#173453)\n\n## Summary\r\n\r\nJust a small Doc Update. In the first example a POST was used and\r\ntowards a non existing handle (`_security` instead of `security`)\r\n\r\nIn the basic license example posted below this one, this is already\r\ncorrect.\r\n\r\n### Checklist\r\n\r\nAll checked - none applied. \r\n(Though first PR in this repository, I am sorry if any mistakes were\r\nmade. If so - please point them out, will do better next time 😅 )\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"96ada947238974a159781013519fe8398593aecc","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","docs","backport:prev-minor","v8.13.0"],"title":"Change POST to PUT and _security to security for API example","number":173453,"url":"https://github.com/elastic/kibana/pull/173453","mergeCommit":{"message":"Change POST to PUT and _security to security for API example (#173453)\n\n## Summary\r\n\r\nJust a small Doc Update. In the first example a POST was used and\r\ntowards a non existing handle (`_security` instead of `security`)\r\n\r\nIn the basic license example posted below this one, this is already\r\ncorrect.\r\n\r\n### Checklist\r\n\r\nAll checked - none applied. \r\n(Though first PR in this repository, I am sorry if any mistakes were\r\nmade. If so - please point them out, will do better next time 😅 )\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"96ada947238974a159781013519fe8398593aecc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173453","number":173453,"mergeCommit":{"message":"Change POST to PUT and _security to security for API example (#173453)\n\n## Summary\r\n\r\nJust a small Doc Update. In the first example a POST was used and\r\ntowards a non existing handle (`_security` instead of `security`)\r\n\r\nIn the basic license example posted below this one, this is already\r\ncorrect.\r\n\r\n### Checklist\r\n\r\nAll checked - none applied. \r\n(Though first PR in this repository, I am sorry if any mistakes were\r\nmade. If so - please point them out, will do better next time 😅 )\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"96ada947238974a159781013519fe8398593aecc"}}]}] BACKPORT--> Co-authored-by: Alex S <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just a small Doc Update. In the first example a POST was used and towards a non existing handle (
_securityinstead ofsecurity)In the basic license example posted below this one, this is already correct.
Checklist
All checked - none applied.
(Though first PR in this repository, I am sorry if any mistakes were made. If so - please point them out, will do better next time 😅 )