[Investigations] - Fix search_filter tests #173325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelolo24
added
release_note:skip
25 tasks
janmonschke
reviewed
Dec 13, 2023
| @@ -64,7 +64,7 @@ export const addDiscoverEsqlQuery = (esqlQuery: string) => { | |||
| cy.get(GET_LOCAL_SEARCH_BAR_SUBMIT_BUTTON(DISCOVER_CONTAINER)).realClick(); | |||
| }; | |||
|
|
|||
| export const convertNBSPToSP = (str: string) => { | |||
| export const convertEditorNonBreakingSpaceToSpace = (str: string) => { | |||
janmonschke
approved these changes
Dec 13, 2023
...test/security_solution_cypress/cypress/e2e/investigations/timelines/esql/search_filter.cy.ts
Show resolved
Hide resolved
...test/security_solution_cypress/cypress/e2e/investigations/timelines/esql/search_filter.cy.ts
Show resolved
Hide resolved
michaelolo24
force-pushed
the
fix-search-filter-tests
branch
from
fee8f4c to
bc75491
Compare
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.13.0
backport:skip
This was referenced Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
There were originally issues about interacting with the editor that prevented the editor from properly being updated, which were fixed here in the
addDiscoverEsqlQueryfn. The original issues below identified were due to a login timeout and the query not properly updating oncy.back. As we do not own the underlying component and behavior, I suspect that specific issue was resolved in the discover component, but investigating and running the flaky test runner to confirm.This fixes the following tests:
Flaky Test Run - Running