Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add docs links for performance tuning presets #173318

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

kpollich
Copy link
Member

@kpollich kpollich commented Dec 13, 2023

Summary

Closes #172523

Adds links to https://www.elastic.co/guide/en/fleet/master/es-output-settings.html#es-output-settings-performance-tuning-settings + help text for the performance preset form input.

image

image

@kpollich kpollich added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 13, 2023
@kpollich kpollich self-assigned this Dec 13, 2023
@kpollich kpollich requested review from a team as code owners December 13, 2023 18:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kpollich kpollich added the release_note:skip Skip the PR/issue when compiling release notes label Dec 13, 2023
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Rule Management - Security Solution Cypress Tests #2 / Related integrations related Integrations Advanced Setting is disabled rules management table should not display a badge with the installed integrations should not display a badge with the installed integrations

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB +671.0B
lists 148.8KB 148.8KB +96.0B
total +767.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 375.1KB 375.2KB +96.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit 1248f55 into elastic:main Dec 13, 2023
45 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Dec 13, 2023
@kpollich kpollich added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Dec 13, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 13, 2023
#173333)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[Fleet] Add docs links for performance tuning presets
(#173318)](#173318)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kyle
Pollich","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-13T20:20:12Z","message":"[Fleet]
Add docs links for performance tuning presets (#173318)\n\n##
Summary\r\n\r\nCloses #172523 \r\n\r\nAdds links
to\r\nhttps://www.elastic.co/guide/en/fleet/master/es-output-settings.html#es-output-settings-performance-tuning-settings\r\n+
help text for the performance preset form
input.\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/6766512/91be33e3-fd62-4973-a2d6-b4f2e544bd69)\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/6766512/787f6784-842f-4e5a-8175-5c2057aee286)","sha":"1248f55d89a2fa69d2a3ddfe167c088643891922","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.13.0"],"number":173318,"url":"https://github.com/elastic/kibana/pull/173318","mergeCommit":{"message":"[Fleet]
Add docs links for performance tuning presets (#173318)\n\n##
Summary\r\n\r\nCloses #172523 \r\n\r\nAdds links
to\r\nhttps://www.elastic.co/guide/en/fleet/master/es-output-settings.html#es-output-settings-performance-tuning-settings\r\n+
help text for the performance preset form
input.\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/6766512/91be33e3-fd62-4973-a2d6-b4f2e544bd69)\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/6766512/787f6784-842f-4e5a-8175-5c2057aee286)","sha":"1248f55d89a2fa69d2a3ddfe167c088643891922"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173318","number":173318,"mergeCommit":{"message":"[Fleet]
Add docs links for performance tuning presets (#173318)\n\n##
Summary\r\n\r\nCloses #172523 \r\n\r\nAdds links
to\r\nhttps://www.elastic.co/guide/en/fleet/master/es-output-settings.html#es-output-settings-performance-tuning-settings\r\n+
help text for the performance preset form
input.\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/6766512/91be33e3-fd62-4973-a2d6-b4f2e544bd69)\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/6766512/787f6784-842f-4e5a-8175-5c2057aee286)","sha":"1248f55d89a2fa69d2a3ddfe167c088643891922"}}]}]
BACKPORT-->

Co-authored-by: Kyle Pollich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.12.0 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Add docs link for performance presets to Fleet output flyout
7 participants