Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.12] Switch "suggest user profiles" API to internal use (#173141) #173249

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.12:

Questions ?

Please refer to the Backport tool documentation

## Summary

With this changes I make "suggestions user profiles" API to be internal
instead of public. We did not reveal it via documentation and it is
better to mark it as an internal API.

This API was introduced in this PR
elastic#170579 and was not released yet.

I also realised that currently the route does not reflect the fact that
it is finding user profiles:

`/api/detection_engine/signals/_find`

The new version will have `users` as part of the path:

`/internal/detection_engine/users/_find`

(cherry picked from commit 7e168c7)
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #76 / discover Discover Saved Queries Manage saved queries updates a saved query

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 66.8KB 66.8KB +6.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @e40pud

@kibanamachine kibanamachine merged commit b1dbf9a into elastic:8.12 Dec 13, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants