Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] - alerts_charts remove brokenInServerlessQA tag #173203

Merged
merged 3 commits into from
Dec 14, 2023
Merged

[Security Solution] - alerts_charts remove brokenInServerlessQA tag #173203

merged 3 commits into from
Dec 14, 2023

Conversation

PhilippeOberti
Copy link
Contributor

@PhilippeOberti PhilippeOberti commented Dec 12, 2023 •
edited
Loading

Summary

This PR focuses on the alerts_charts.cy.ts Cypress test file.

  • remove the brokenInServerlessQA tag (the test was verified with Glo)
  • clean alerts and rules before each test
  • improve test titles

Flaky test runner in progress https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4519

#170520

@PhilippeOberti PhilippeOberti added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team labels Dec 12, 2023
@PhilippeOberti PhilippeOberti requested review from a team as code owners December 12, 2023 20:04
@PhilippeOberti PhilippeOberti changed the title [Security Solution] - remove brokenInServerlessQA tag [Security Solution] - alerts_charts remove brokenInServerlessQA tag Dec 12, 2023
janmonschke
janmonschke approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@janmonschke janmonschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #4 / Timeline Templates Creates a timeline template Creates a timeline template

Metrics [docs]

✅ unchanged

History

  • 💛 Build #183277 was flaky 09c4624148efdbf0621f044f1abf453c3b062355

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@PhilippeOberti PhilippeOberti merged commit 0a73b99 into elastic:main Dec 14, 2023
38 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Dec 14, 2023
@PhilippeOberti PhilippeOberti mentioned this pull request Dec 14, 2023
Closed
@PhilippeOberti PhilippeOberti deleted the cypress-alerts-charts branch December 14, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janmonschke janmonschke janmonschke approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PhilippeOberti @kibana-ci @janmonschke @kibanamachine