Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ObsUx] Trace timeline: Change the missing trace items warning message #173196

Merged
merged 3 commits into from
Dec 14, 2023
Merged

[ObsUx] Trace timeline: Change the missing trace items warning message #173196

merged 3 commits into from
Dec 14, 2023

Conversation

jennypavlova
Copy link
Member

Closes #173134

Summary

This PR is a follow-up to #171196 and changes the missing trace items tooltip message.

image

Testing

Same as in #171196 (comment) but the message should be changed to the one in the screenshot here

@jennypavlova jennypavlova self-assigned this Dec 12, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@jennypavlova jennypavlova added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Dec 12, 2023
@jennypavlova jennypavlova mentioned this pull request Dec 12, 2023
Merged
@jennypavlova jennypavlova marked this pull request as ready for review December 13, 2023 13:58
@jennypavlova jennypavlova requested a review from a team as a code owner December 13, 2023 13:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

sorenlouv
sorenlouv approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jennypavlova
Copy link
Member Author

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.7MB 3.7MB +170.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jennypavlova

@jennypavlova jennypavlova merged commit ade658c into elastic:main Dec 14, 2023
41 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

@jennypavlova jennypavlova

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ObsUx] Trace timeline: Change the missing trace items warning message
6 participants
@jennypavlova @apmmachine @elasticmachine @kibana-ci @sorenlouv @kibanamachine