Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ObsUX] Add Profiling prompt to Host CPU card #173177

Conversation

mykolaharmash
Copy link
Contributor

@mykolaharmash mykolaharmash commented Dec 12, 2023

Closes #173150

This adds a prompt under the CPU card to open the Profiling tab.

CleanShot 2023-12-12 at 16 56 55@2x

@mykolaharmash mykolaharmash requested a review from a team as a code owner December 12, 2023 15:57
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mykolaharmash mykolaharmash added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Dec 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@mykolaharmash mykolaharmash added the release_note:skip Skip the PR/issue when compiling release notes label Dec 12, 2023
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mykolaharmash
Copy link
Contributor Author

@elasticmachine merge upstream

@mykolaharmash mykolaharmash enabled auto-merge (squash) December 12, 2023 16:07
@mykolaharmash
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1329 1330 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.9MB 1.9MB +842.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mykolaharmash mykolaharmash merged commit 669235a into elastic:main Dec 13, 2023
38 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 13, 2023
Closes elastic#173150

This adds a prompt under the CPU card to open the Profiling tab.

![CleanShot 2023-12-12 at 16 56
55@2x](https://github.com/elastic/kibana/assets/793851/5beae41d-45da-426f-9d38-eb4b4376b346)

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 669235a)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 13, 2023
# Backport

This will backport the following commits from `main` to `8.12`:
- [[ObsUX] Add Profiling prompt to Host CPU card
(#173177)](#173177)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Mykola
Harmash","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-13T10:25:59Z","message":"[ObsUX]
Add Profiling prompt to Host CPU card (#173177)\n\nCloses
https://github.com/elastic/kibana/issues/173150\r\n\r\nThis adds a
prompt under the CPU card to open the Profiling tab.\r\n\r\n![CleanShot
2023-12-12 at 16
56\r\n55@2x](https://github.com/elastic/kibana/assets/793851/5beae41d-45da-426f-9d38-eb4b4376b346)\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"669235a79897b414202b4752704067496b82d488","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.12.0","Team:obs-ux-infra_services","v8.13.0"],"number":173177,"url":"https://github.com/elastic/kibana/pull/173177","mergeCommit":{"message":"[ObsUX]
Add Profiling prompt to Host CPU card (#173177)\n\nCloses
https://github.com/elastic/kibana/issues/173150\r\n\r\nThis adds a
prompt under the CPU card to open the Profiling tab.\r\n\r\n![CleanShot
2023-12-12 at 16
56\r\n55@2x](https://github.com/elastic/kibana/assets/793851/5beae41d-45da-426f-9d38-eb4b4376b346)\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"669235a79897b414202b4752704067496b82d488"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173177","number":173177,"mergeCommit":{"message":"[ObsUX]
Add Profiling prompt to Host CPU card (#173177)\n\nCloses
https://github.com/elastic/kibana/issues/173150\r\n\r\nThis adds a
prompt under the CPU card to open the Profiling tab.\r\n\r\n![CleanShot
2023-12-12 at 16
56\r\n55@2x](https://github.com/elastic/kibana/assets/793851/5beae41d-45da-426f-9d38-eb4b4376b346)\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"669235a79897b414202b4752704067496b82d488"}}]}]
BACKPORT-->

Co-authored-by: Mykola Harmash <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.12.0 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ObxUX][Profiling, Infra] Add link to profiling under host's CPU card
6 participants