Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs Explorer] Disable the too-slow url check in functional test #173092

Merged

Conversation

weltenwort
Copy link
Member

📝 Summary

This sets ensureCurrentUrl to false in the Observability Logs Explorer page object, because it seems to be too slow sometimes. Therefore it misses the right moment before the URL is rewritten by the app and fails unnecessarily.

closes #167515

@weltenwort weltenwort added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team Feature:LogsExplorer Logs Explorer feature labels Dec 11, 2023
@weltenwort weltenwort self-assigned this Dec 11, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@weltenwort
Copy link
Member Author

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @weltenwort

Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this fix!

@achyutjhunjhunwala
Copy link
Contributor

achyutjhunjhunwala commented Dec 12, 2023

Thank you for identifying and fixing this. I am pretty sure this could fix a lot of Flaky tests.
@weltenwort Any specific reason to keep this PR still in Draft Stage ?

@weltenwort weltenwort marked this pull request as ready for review December 12, 2023 11:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@weltenwort
Copy link
Member Author

Thanks for the review!

Any specific reason to keep this PR still in Draft Stage?

No, I just like to have a green CI run before I bother anyone with review requests

@weltenwort weltenwort merged commit 50cc8b8 into elastic:main Dec 12, 2023
43 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:LogsExplorer Logs Explorer feature release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.13.0
Projects
None yet
7 participants