-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs Explorer] Disable the too-slow url check in functional test #173092
[Logs Explorer] Disable the too-slow url check in functional test #173092
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
/ci |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @weltenwort |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this fix!
Thank you for identifying and fixing this. I am pretty sure this could fix a lot of Flaky tests. |
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
Thanks for the review!
No, I just like to have a green CI run before I bother anyone with review requests |
📝 Summary
This sets
ensureCurrentUrl
tofalse
in the Observability Logs Explorer page object, because it seems to be too slow sometimes. Therefore it misses the right moment before the URL is rewritten by the app and fails unnecessarily.closes #167515