Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONSOLE] Autocomplete for the inference API #173014

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

davidkyle
Copy link
Member

@davidkyle davidkyle commented Dec 10, 2023

Summary

This PR adds the to autocomplete definitions in Console for the _inference API

The definitions were generated from ES specification repo at commit elastic/elasticsearch-specification@de45840 using the command node scripts/generate_console_definitions.js --source /PATH/TO/elasticsearch-specification --emptyDest

4 files are added for GET, PUT, POST, DELETE and there is a small update to the ml start deployment API

@davidkyle davidkyle added backport Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes v8.12.0 v8.13.0 labels Dec 10, 2023
@davidkyle davidkyle requested a review from a team as a code owner December 10, 2023 22:20
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@davidkyle davidkyle merged commit 61cd731 into elastic:main Dec 11, 2023
44 of 45 checks passed
@davidkyle
Copy link
Member Author

Thanks for the review @yuliacech

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 11, 2023
This PR adds the to autocomplete definitions in Console for the _inference API

(cherry picked from commit 61cd731)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 11, 2023
# Backport

This will backport the following commits from `main` to `8.12`:
- [[CONSOLE] Autocomplete for the inference API
(#173014)](#173014)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"David
Kyle","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-11T16:41:26Z","message":"[CONSOLE]
Autocomplete for the inference API (#173014)\n\nThis PR adds the to
autocomplete definitions in Console for the _inference
API","sha":"61cd731417208a601d50330b9da069be11a339c5","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","Feature:Console","release_note:skip","v8.12.0","v8.13.0"],"number":173014,"url":"https://github.com/elastic/kibana/pull/173014","mergeCommit":{"message":"[CONSOLE]
Autocomplete for the inference API (#173014)\n\nThis PR adds the to
autocomplete definitions in Console for the _inference
API","sha":"61cd731417208a601d50330b9da069be11a339c5"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173014","number":173014,"mergeCommit":{"message":"[CONSOLE]
Autocomplete for the inference API (#173014)\n\nThis PR adds the to
autocomplete definitions in Console for the _inference
API","sha":"61cd731417208a601d50330b9da069be11a339c5"}}]}] BACKPORT-->

Co-authored-by: David Kyle <[email protected]>
droberts195 added a commit that referenced this pull request Mar 6, 2024
The dev console command completion files now correctly state that the
inference APIs are available in serverless.

Followup to #173014 and elastic/elasticsearch-specification#2414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes v8.12.0 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants