-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CONSOLE] Autocomplete for the inference API #173014
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkyle
added
backport
Feature:Console
Dev Tools Console Feature
release_note:skip
Skip the PR/issue when compiling release notes
v8.12.0
v8.13.0
labels
Dec 10, 2023
💛 Build succeeded, but was flaky
Failed CI Steps
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
yuliacech
approved these changes
Dec 11, 2023
Thanks for the review @yuliacech |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 11, 2023
This PR adds the to autocomplete definitions in Console for the _inference API (cherry picked from commit 61cd731)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 11, 2023
# Backport This will backport the following commits from `main` to `8.12`: - [[CONSOLE] Autocomplete for the inference API (#173014)](#173014) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"David Kyle","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-11T16:41:26Z","message":"[CONSOLE] Autocomplete for the inference API (#173014)\n\nThis PR adds the to autocomplete definitions in Console for the _inference API","sha":"61cd731417208a601d50330b9da069be11a339c5","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","Feature:Console","release_note:skip","v8.12.0","v8.13.0"],"number":173014,"url":"https://github.com/elastic/kibana/pull/173014","mergeCommit":{"message":"[CONSOLE] Autocomplete for the inference API (#173014)\n\nThis PR adds the to autocomplete definitions in Console for the _inference API","sha":"61cd731417208a601d50330b9da069be11a339c5"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173014","number":173014,"mergeCommit":{"message":"[CONSOLE] Autocomplete for the inference API (#173014)\n\nThis PR adds the to autocomplete definitions in Console for the _inference API","sha":"61cd731417208a601d50330b9da069be11a339c5"}}]}] BACKPORT--> Co-authored-by: David Kyle <[email protected]>
droberts195
added a commit
that referenced
this pull request
Mar 6, 2024
The dev console command completion files now correctly state that the inference APIs are available in serverless. Followup to #173014 and elastic/elasticsearch-specification#2414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Feature:Console
Dev Tools Console Feature
release_note:skip
Skip the PR/issue when compiling release notes
v8.12.0
v8.13.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the to autocomplete definitions in Console for the _inference API
The definitions were generated from ES specification repo at commit elastic/elasticsearch-specification@de45840 using the command
node scripts/generate_console_definitions.js --source /PATH/TO/elasticsearch-specification --emptyDest
4 files are added for GET, PUT, POST, DELETE and there is a small update to the ml start deployment API