Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small typo corrections in entity-analytics #172994

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Small typo corrections in entity-analytics #172994

merged 4 commits into from
Dec 12, 2023

Conversation

jaredburgettelastic
Copy link
Contributor

Summary

Corrects typos within entity-analytics comments

@jaredburgettelastic jaredburgettelastic requested a review from a team as a code owner December 8, 2023 20:11
@jaredburgettelastic jaredburgettelastic added ci:project-deploy-security Create a Security Serverless Project release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Dec 8, 2023
rylnd
rylnd approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

x-pack/plugins/security_solution/server/lib/entity_analytics/utils/create_datastream.ts Outdated Show resolved Hide resolved
@jaredburgettelastic jaredburgettelastic added the ci:project-persist-deployment Persist project deployment indefinitely label Dec 10, 2023
@jaredburgettelastic
Copy link
Contributor Author

@elasticmachine merge upstream

@jaredburgettelastic
Copy link
Contributor Author

@elasticmachine merge upstream

@jaredburgettelastic jaredburgettelastic enabled auto-merge (squash) December 12, 2023 18:44
@kibana-ci
Copy link
Collaborator

kibana-ci commented Dec 12, 2023 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5713 +5713
total size - 5.9MB +5.9MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jaredburgettelastic jaredburgettelastic merged commit e52fb76 into elastic:main Dec 12, 2023
51 checks passed
@jaredburgettelastic jaredburgettelastic deleted the entity-analytics-test-env-creation branch December 12, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylnd rylnd rylnd approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-security Create a Security Serverless Project ci:project-persist-deployment Persist project deployment indefinitely release_note:skip Skip the PR/issue when compiling release notes v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaredburgettelastic @kibana-ci @rylnd @kibanamachine