Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAM][Maintenance Window] MW scoped query language improvements #172993

Merged

Conversation

JiaweiWu
Copy link
Contributor

@JiaweiWu JiaweiWu commented Dec 8, 2023

Summary

Some language improvements for maintenance window scoped queries.

Before

image

After

image

@JiaweiWu JiaweiWu added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesManagement Issues related to the Rules Management UX v8.12.0 v8.13.0 labels Dec 8, 2023
@JiaweiWu JiaweiWu requested a review from lcawl December 8, 2023 20:08
@JiaweiWu JiaweiWu requested a review from a team as a code owner December 8, 2023 20:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@JiaweiWu
Copy link
Contributor Author

@elasticmachine merge upstream

@JiaweiWu
Copy link
Contributor Author

JiaweiWu commented Jan 2, 2024

@elasticmachine merge upstream

@JiaweiWu JiaweiWu requested a review from lcawl January 3, 2024 18:54
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
alerting 88.7KB 88.7KB +27.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@JiaweiWu JiaweiWu merged commit 845cd06 into elastic:main Jan 5, 2024
37 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 5, 2024
…tic#172993)

## Summary

Some language improvements for maintenance window scoped queries.

### Before

![image](https://github.com/elastic/kibana/assets/74562234/f9fa39f9-f057-4dc5-9a6f-91ef85f0de79)

### After

![image](https://github.com/elastic/kibana/assets/26471269/c6e409cd-634a-4c62-b85d-6ad867afe4cd)

---------

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Lisa Cawley <[email protected]>
(cherry picked from commit 845cd06)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 5, 2024
#172993) (#174390)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[RAM][Maintenance Window] MW scoped query language improvements
(#172993)](#172993)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jiawei
Wu","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-05T19:31:44Z","message":"[RAM][Maintenance
Window] MW scoped query language improvements (#172993)\n\n##
Summary\r\n\r\nSome language improvements for maintenance window scoped
queries.\r\n\r\n###
Before\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/74562234/f9fa39f9-f057-4dc5-9a6f-91ef85f0de79)\r\n\r\n\r\n###
After\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/26471269/c6e409cd-634a-4c62-b85d-6ad867afe4cd)\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>\r\nCo-authored-by:
Lisa Cawley
<[email protected]>","sha":"845cd06d9aca6b7e33cac5b037c30e5c536fbbf2","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Alerting/RulesManagement","v8.12.0","v8.13.0"],"title":"[RAM][Maintenance
Window] MW scoped query language improvements
","number":172993,"url":"https://github.com/elastic/kibana/pull/172993","mergeCommit":{"message":"[RAM][Maintenance
Window] MW scoped query language improvements (#172993)\n\n##
Summary\r\n\r\nSome language improvements for maintenance window scoped
queries.\r\n\r\n###
Before\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/74562234/f9fa39f9-f057-4dc5-9a6f-91ef85f0de79)\r\n\r\n\r\n###
After\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/26471269/c6e409cd-634a-4c62-b85d-6ad867afe4cd)\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>\r\nCo-authored-by:
Lisa Cawley
<[email protected]>","sha":"845cd06d9aca6b7e33cac5b037c30e5c536fbbf2"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172993","number":172993,"mergeCommit":{"message":"[RAM][Maintenance
Window] MW scoped query language improvements (#172993)\n\n##
Summary\r\n\r\nSome language improvements for maintenance window scoped
queries.\r\n\r\n###
Before\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/74562234/f9fa39f9-f057-4dc5-9a6f-91ef85f0de79)\r\n\r\n\r\n###
After\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/26471269/c6e409cd-634a-4c62-b85d-6ad867afe4cd)\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>\r\nCo-authored-by:
Lisa Cawley
<[email protected]>","sha":"845cd06d9aca6b7e33cac5b037c30e5c536fbbf2"}}]}]
BACKPORT-->

Co-authored-by: Jiawei Wu <[email protected]>
delanni pushed a commit to delanni/kibana that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants