Fix: kibana-keystore requires kibana.yml starting 8.11.2 #172938
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delanni
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
|
buildkite test this |
|
buildkite test this |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
|
Closing, as this will probably not be the final solution - for now we decided to revert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #172919
In a specific use case, the Keystore would be used in a context where one of the default configs is not present, causing an error from opening a non-existent file. That's because
findFilewill default to the first file path, if no file is found. This path would later be read, causing an error.The fix wraps the config path acquisition with a try-catch, defaulting to
undefined. Thisundefinedwill then be skipped when enumerating the data path options.fix: Fixes an issue where the keystore would crash if used with no available config