[Lens] Displays the suggestions on the dataview mode #172924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
added
release_note:enhancement
Feature:Lens
backport:skip
|
/ci |
|
/ci |
|
/ci |
stratoula
added
the
Team:Visualizations
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
davismcphee
approved these changes
Dec 9, 2023
|
Thanx @davismcphee, it is not but I will take a look. Update: Fixed |
|
/ci |
|
The bug that Davis describes is also in main and I want to backport it in 8.12 so I am solving these bugs in another PR #173490 |
|
/ci |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
Taking a look at this now! |
drewdaemon
approved these changes
Dec 19, 2023
Comment on lines
+169
to
+175
| it('should not display the suggestions if hidesSuggestions prop is true', async () => { | ||
| renderConfigFlyout({ | ||
| hidesSuggestions: true, | ||
| }); | ||
| expect(screen.queryByTestId('InlineEditingSuggestions')).toBeNull(); | ||
| }); | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enables the suggestions for the dataview mode charts in the in-app flyout. It works exactly as in ES|QL mode. In Discover we still hide them from the flyout as they appear on the breakdown above the chart. We are going to add them in Discover too but in a follow up PR propably.
Checklist