Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language client getting started dedicated #172869

Merged

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented Dec 7, 2023

Summary

This adds the getting started page from Serverless Elasticsearch to Dedicated.

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.12.0 labels Dec 7, 2023
@sphilipse sphilipse requested a review from a team December 7, 2023 18:45
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM

@sphilipse sphilipse enabled auto-merge (squash) December 8, 2023 17:06
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2262 2260 -2
indexManagement 599 601 +2
total -0

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/search-api-panels 66 75 +9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.7MB 2.7MB -23.9KB
indexManagement 585.2KB 585.3KB +87.0B
serverlessSearch 377.1KB 377.1KB +36.0B
total -23.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
enterpriseSearch 41.0KB 41.0KB +15.0B
Unknown metric groups

API count

id before after diff
@kbn/search-api-panels 66 75 +9

async chunk count

id before after diff
enterpriseSearch 18 19 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sphilipse sphilipse merged commit 8b9ce18 into elastic:main Dec 8, 2023
37 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 8, 2023
## Summary

This adds the getting started page from Serverless Elasticsearch to
Dedicated.

(cherry picked from commit 8b9ce18)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 8, 2023
# Backport

This will backport the following commits from `main` to `8.12`:
- [Language client getting started dedicated
(#172869)](#172869)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-08T18:48:56Z","message":"Language
client getting started dedicated (#172869)\n\n## Summary\r\n\r\nThis
adds the getting started page from Serverless Elasticsearch
to\r\nDedicated.","sha":"8b9ce1848ca59291a759396e61389a76e0d17133","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.12.0","v8.13.0"],"number":172869,"url":"https://github.com/elastic/kibana/pull/172869","mergeCommit":{"message":"Language
client getting started dedicated (#172869)\n\n## Summary\r\n\r\nThis
adds the getting started page from Serverless Elasticsearch
to\r\nDedicated.","sha":"8b9ce1848ca59291a759396e61389a76e0d17133"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172869","number":172869,"mergeCommit":{"message":"Language
client getting started dedicated (#172869)\n\n## Summary\r\n\r\nThis
adds the getting started page from Serverless Elasticsearch
to\r\nDedicated.","sha":"8b9ce1848ca59291a759396e61389a76e0d17133"}}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.12.0 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants