Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Filter Overflow When To Much Filters Active #172860

Merged
merged 5 commits into from
Dec 11, 2023
Merged

[Cases] Filter Overflow When To Much Filters Active #172860

merged 5 commits into from
Dec 11, 2023

Conversation

jcger
Copy link
Contributor

@jcger jcger commented Dec 7, 2023 •
edited by kibanamachine
Loading

Closes #172855

Screenshot

@jcger jcger added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.12.0 labels Dec 7, 2023
@jcger jcger requested a review from a team as a code owner December 7, 2023 17:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@jcger jcger requested a review from a team as a code owner December 7, 2023 17:45
@jcger jcger removed the request for review from a team December 7, 2023 17:47
cnasikas
cnasikas requested changes Dec 8, 2023
View reviewed changes
Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Tested and is working as expected. Blocking to avoid accidentally merging code with dangerouslySetInnerHTML.

x-pack/plugins/cases/public/components/all_cases/multi_select_filter.tsx Outdated Show resolved Hide resolved
@cnasikas cnasikas added bug Fixes for quality problems that affect the customer experience v8.13.0 labels Dec 8, 2023
adcoelho
adcoelho approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@adcoelho adcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected. Really like how it looks 👌

jcger
jcger commented Dec 11, 2023
View reviewed changes
x-pack/plugins/cases/public/components/all_cases/assignees_filter.tsx
nullOptionLabel: i18n.NO_ASSIGNEES,
}}
/>
<EuiFilterGroup>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to include this because, without it, the selectable styling breaks. It means that we are wrapping every single selectable in a filter group (a one filter only filter group) which might not be ideal semantically

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 443.5KB 443.9KB +436.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cnasikas
cnasikas approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I also really like how it looks like.

js-jankisalvi
js-jankisalvi approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome 🎉

@jcger jcger merged commit f7b0e49 into elastic:main Dec 11, 2023
38 checks passed
@kibanamachine kibanamachine mentioned this pull request Dec 11, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 11, 2023
@jcger
[Cases] Filter Overflow When To Much Filters Active (elastic#172860)
32e6fcc 
Closes elastic#172855

![Screenshot](https://github.com/elastic/kibana/assets/17549662/19537708-5fda-4773-a85c-f21344cab4cc)

(cherry picked from commit f7b0e49)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 11, 2023
@kibanamachine @jcger
[8.12] [Cases] Filter Overflow When To Much Filters Active (#172860) (#…
6333a72 
…173045)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[Cases] Filter Overflow When To Much Filters Active
(#172860)](#172860)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julian
Gernun","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-11T12:33:34Z","message":"[Cases]
Filter Overflow When To Much Filters Active (#172860)\n\nCloses
https://github.com/elastic/kibana/issues/172855\r\n\r\n\r\n![Screenshot](https://github.com/elastic/kibana/assets/17549662/19537708-5fda-4773-a85c-f21344cab4cc)","sha":"f7b0e49e2f81cf4e995f6877731281db01566909","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","Feature:Cases","v8.12.0","v8.13.0"],"number":172860,"url":"https://github.com/elastic/kibana/pull/172860","mergeCommit":{"message":"[Cases]
Filter Overflow When To Much Filters Active (#172860)\n\nCloses
https://github.com/elastic/kibana/issues/172855\r\n\r\n\r\n![Screenshot](https://github.com/elastic/kibana/assets/17549662/19537708-5fda-4773-a85c-f21344cab4cc)","sha":"f7b0e49e2f81cf4e995f6877731281db01566909"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172860","number":172860,"mergeCommit":{"message":"[Cases]
Filter Overflow When To Much Filters Active (#172860)\n\nCloses
https://github.com/elastic/kibana/issues/172855\r\n\r\n\r\n![Screenshot](https://github.com/elastic/kibana/assets/17549662/19537708-5fda-4773-a85c-f21344cab4cc)","sha":"f7b0e49e2f81cf4e995f6877731281db01566909"}}]}]
BACKPORT-->

Co-authored-by: Julian Gernun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js-jankisalvi js-jankisalvi js-jankisalvi approved these changes

@cnasikas cnasikas cnasikas approved these changes

@adcoelho adcoelho adcoelho approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0 v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cases] Filter Overflow When To Much Filters Active
7 participants
@jcger @elasticmachine @kibana-ci @kibanamachine @adcoelho @cnasikas @js-jankisalvi