Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] [AIOps] Fixing log pattern analysis test #172854

Merged
merged 13 commits into from
Dec 19, 2023
Merged

[ML] [AIOps] Fixing log pattern analysis test #172854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a83eca1
[ML] [AIOps] Fixing log pattern analysis test
jgowdyelastic Dec 7, 2023
a474f8f
Merge branch 'main' into fixing-log-pattern-analysis-test
jgowdyelastic Dec 7, 2023
a34a885
Merge branch 'main' into fixing-log-pattern-analysis-test
jgowdyelastic Dec 8, 2023
6499b97
fixing test in discover
jgowdyelastic Dec 8, 2023
7b0e8c6
fixing scope issue
jgowdyelastic Dec 8, 2023
7ddeb4d
Merge branch 'main' into fixing-log-pattern-analysis-test
jgowdyelastic Dec 8, 2023
961a080
Merge branch 'main' into fixing-log-pattern-analysis-test
jgowdyelastic Dec 8, 2023
44a9337
removing selection assert
jgowdyelastic Dec 8, 2023
d730d3a
Merge branch 'main' into fixing-log-pattern-analysis-test
jgowdyelastic Dec 8, 2023
53665f6
Merge branch 'main' into fixing-log-pattern-analysis-test
jgowdyelastic Dec 12, 2023
8752d0c
Merge branch 'main' into fixing-log-pattern-analysis-test
jgowdyelastic Dec 18, 2023
7dad0bd
fixing test
jgowdyelastic Dec 18, 2023
ddc37dc
changing to >= count check
jgowdyelastic Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions x-pack/test/functional/apps/aiops/log_pattern_analysis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
});
}

// FLAKY: https://github.com/elastic/kibana/issues/172739
describe.skip('log pattern analysis', async function () {
describe('log pattern analysis', async function () {
let tabsCount = 1;

afterEach(async () => {
Expand Down Expand Up @@ -55,8 +54,10 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await aiops.logPatternAnalysisPage.assertLogPatternAnalysisPageExists();

await aiops.logPatternAnalysisPage.clickUseFullDataButton(totalDocCount);
await aiops.logPatternAnalysisPage.setRandomSamplingOption('aiopsRandomSamplerOptionOff');
await aiops.logPatternAnalysisPage.selectCategoryField(selectedField);
await aiops.logPatternAnalysisPage.clickRunButton();

await aiops.logPatternAnalysisPage.assertTotalCategoriesFound(3);
await aiops.logPatternAnalysisPage.assertCategoryTableRows(3);

Expand All @@ -82,6 +83,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await aiops.logPatternAnalysisPage.assertLogPatternAnalysisPageExists();

await aiops.logPatternAnalysisPage.clickUseFullDataButton(totalDocCount);
await aiops.logPatternAnalysisPage.setRandomSamplingOption('aiopsRandomSamplerOptionOff');
await aiops.logPatternAnalysisPage.selectCategoryField(selectedField);
await aiops.logPatternAnalysisPage.clickRunButton();
await aiops.logPatternAnalysisPage.assertTotalCategoriesFound(3);
Expand Down
7 changes: 5 additions & 2 deletions x-pack/test/functional/apps/aiops/log_pattern_analysis_in_discover.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
});
}

// FLAKY: https://github.com/elastic/kibana/issues/172770
describe.skip('log pattern analysis', async function () {
describe('log pattern analysis', async function () {
let tabsCount = 1;

afterEach(async () => {
Expand Down Expand Up @@ -62,6 +61,8 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await aiops.logPatternAnalysisPage.assertLogPatternAnalysisFlyoutExists();
await aiops.logPatternAnalysisPage.assertLogPatternAnalysisFlyoutTitle(selectedField);

await aiops.logPatternAnalysisPage.setRandomSamplingOption('aiopsRandomSamplerOptionOff');

await aiops.logPatternAnalysisPage.assertTotalCategoriesFound(3);
await aiops.logPatternAnalysisPage.assertCategoryTableRows(3);

Expand Down Expand Up @@ -92,6 +93,8 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await aiops.logPatternAnalysisPage.assertLogPatternAnalysisFlyoutExists();
await aiops.logPatternAnalysisPage.assertLogPatternAnalysisFlyoutTitle(selectedField);

await aiops.logPatternAnalysisPage.setRandomSamplingOption('aiopsRandomSamplerOptionOff');

await aiops.logPatternAnalysisPage.assertTotalCategoriesFound(3);
await aiops.logPatternAnalysisPage.assertCategoryTableRows(3);

Expand Down
41 changes: 32 additions & 9 deletions x-pack/test/functional/services/aiops/log_pattern_analysis_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ export function LogPatternAnalysisPageProvider({ getService, getPageObject }: Ft
const testSubjects = getService('testSubjects');
const comboBox = getService('comboBox');

type RandomSamplerOption =
| 'aiopsRandomSamplerOptionOnAutomatic'
| 'aiopsRandomSamplerOptionOnManual'
| 'aiopsRandomSamplerOptionOff';

return {
async assertLogPatternAnalysisPageExists() {
await retry.tryForTime(30 * 1000, async () => {
Expand Down Expand Up @@ -60,25 +65,25 @@ export function LogPatternAnalysisPageProvider({ getService, getPageObject }: Ft
});
},

async assertTotalCategoriesFound(expectedCategoryCount: number) {
const expectedText = `${expectedCategoryCount} patterns found`;
async assertTotalCategoriesFound(expectedMinimumCategoryCount: number) {
await retry.tryForTime(5000, async () => {
const actualText = await testSubjects.getVisibleText('aiopsLogPatternsFoundCount');
expect(actualText).to.eql(
expectedText,
`Expected patterns found count to be '${expectedText}' (got '${actualText}')`
const actualCount = Number(actualText.split(' ')[0]);
expect(actualCount + 1).to.greaterThan(
expectedMinimumCategoryCount,
`Expected patterns found count to be >= '${expectedMinimumCategoryCount}' (got '${actualCount}')`
);
});
},

async assertCategoryTableRows(expectedCategoryCount: number) {
async assertCategoryTableRows(expectedMinimumCategoryCount: number) {
await retry.tryForTime(5000, async () => {
const tableListContainer = await testSubjects.find('aiopsLogPatternsTable');
const rows = await tableListContainer.findAllByClassName('euiTableRow');

expect(rows.length).to.eql(
expectedCategoryCount,
`Expected number of rows in table to be '${expectedCategoryCount}' (got '${rows.length}')`
expect(rows.length + 1).to.greaterThan(
expectedMinimumCategoryCount,
`Expected number of rows in table to be >= '${expectedMinimumCategoryCount}' (got '${rows.length}')`
);
});
},
Expand Down Expand Up @@ -176,5 +181,23 @@ export function LogPatternAnalysisPageProvider({ getService, getPageObject }: Ft
);
});
},

async setRandomSamplingOption(option: RandomSamplerOption) {
await retry.tryForTime(20000, async () => {
await testSubjects.existOrFail('aiopsLogPatternAnalysisShowSamplingOptionsButton');
await testSubjects.clickWhenNotDisabled('aiopsLogPatternAnalysisShowSamplingOptionsButton');

await testSubjects.clickWhenNotDisabled('aiopsRandomSamplerOptionsSelect');

await testSubjects.existOrFail('aiopsRandomSamplerOptionOff', { timeout: 1000 });
await testSubjects.existOrFail('aiopsRandomSamplerOptionOnManual', { timeout: 1000 });
await testSubjects.existOrFail('aiopsRandomSamplerOptionOnAutomatic', { timeout: 1000 });

await testSubjects.click(option);

await testSubjects.clickWhenNotDisabled('aiopsLogPatternAnalysisShowSamplingOptionsButton');
await testSubjects.missingOrFail('aiopsRandomSamplerOptionsFormRow', { timeout: 1000 });
});
},
};
}
Loading