Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] address pr nit comments #172853

Merged
merged 4 commits into from
Dec 13, 2023
Merged

[Cloud Security] address pr nit comments #172853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90c9a23
address pr nit comments
Omolola-Akinleye Dec 7, 2023
d3fe47c
merge main into branch and resolve conflict
Omolola-Akinleye Dec 11, 2023
b688f85
fix module export to use types old
Omolola-Akinleye Dec 11, 2023
096cb3b
Merge branch 'main' into compliance-dashboard-pr-chore
Omolola-Akinleye Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions x-pack/plugins/cloud_security_posture/common/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ export const RULE_FAILED = `failed`;

export const POSTURE_TYPE_ALL = 'all';

export const CSPM_FINDINGS_STATS_INTERVAL = 5;

// A mapping of in-development features to their status. These features should be hidden from users but can be easily
// activated via a simple code change in a single location.
export const INTERNAL_FEATURE_FLAGS = {
Expand Down
4 changes: 2 additions & 2 deletions ...ty_posture/public/pages/compliance_dashboard/compliance_charts/compliance_score_chart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ const CompactPercentageLabels = ({
</>
);

const NonCompactPercentageLabels = ({
const PercentageLabels = ({
onEvalCounterClick,
stats,
}: {
Expand Down Expand Up @@ -301,7 +301,7 @@ export const ComplianceScoreChart = ({
onEvalCounterClick={onEvalCounterClick}
/>
) : (
<NonCompactPercentageLabels
<PercentageLabels
stats={{ totalPassed: data.totalPassed, totalFailed: data.totalFailed }}
onEvalCounterClick={onEvalCounterClick}
/>
Expand Down
6 changes: 4 additions & 2 deletions x-pack/plugins/cloud_security_posture/server/routes/compliance_dashboard/get_trends.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@

import { ElasticsearchClient, Logger } from '@kbn/core/server';
import { calculatePostureScore } from '../../../common/utils/helpers';
import { BENCHMARK_SCORE_INDEX_DEFAULT_NS } from '../../../common/constants';
import {
BENCHMARK_SCORE_INDEX_DEFAULT_NS,
CSPM_FINDINGS_STATS_INTERVAL,
} from '../../../common/constants';
import type { PosturePolicyTemplate, Stats } from '../../../common/types_old';
import { toBenchmarkDocFieldKey } from '../../lib/mapping_field_util';
import { CSPM_FINDINGS_STATS_INTERVAL } from '../../tasks/findings_stats_task';

interface FindingsDetails {
total_findings: number;
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/cloud_security_posture/server/tasks/findings_stats_task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import { getIdentifierRuntimeMapping } from '../../common/runtime_mappings/get_i
import { FindingsStatsTaskResult, ScoreByPolicyTemplateBucket, VulnSeverityAggs } from './types';
import {
BENCHMARK_SCORE_INDEX_DEFAULT_NS,
CSPM_FINDINGS_STATS_INTERVAL,
LATEST_FINDINGS_INDEX_DEFAULT_NS,
LATEST_VULNERABILITIES_INDEX_DEFAULT_NS,
VULNERABILITIES_SEVERITY,
Expand All @@ -36,7 +37,6 @@ import { toBenchmarkMappingFieldKey } from '../lib/mapping_field_util';

const CSPM_FINDINGS_STATS_TASK_ID = 'cloud_security_posture-findings_stats';
const CSPM_FINDINGS_STATS_TASK_TYPE = 'cloud_security_posture-stats_task';
export const CSPM_FINDINGS_STATS_INTERVAL = 5;

export async function scheduleFindingsStatsTask(
taskManager: TaskManagerStartContract,
Expand Down
Loading