[Fleet] Fix 500 in Fleet API when request to product versions endpoint throws ECONNREFUSED #172850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpollich
added
release_note:fix
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
jlind23
approved these changes
Dec 7, 2023
nchaulet
reviewed
Dec 7, 2023
nchaulet
approved these changes
Dec 7, 2023
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
To update your PR or re-run it, just comment with: cc @kpollich |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 7, 2023
…t throws ECONNREFUSED (elastic#172850) ## Summary Network-level errors will cause `fetch` to `throw` rather than resolving with a status code. This PR updates our logic to handle this case for airgapped environments where `ECONNREFUSED` style errors squash HTTP requests at the DNS level. (cherry picked from commit be6fbc4)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 7, 2023
…t throws ECONNREFUSED (elastic#172850) ## Summary Network-level errors will cause `fetch` to `throw` rather than resolving with a status code. This PR updates our logic to handle this case for airgapped environments where `ECONNREFUSED` style errors squash HTTP requests at the DNS level. (cherry picked from commit be6fbc4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 7, 2023
…endpoint throws ECONNREFUSED (#172850) (#172865) # Backport This will backport the following commits from `main` to `8.12`: - [[Fleet] Fix 500 in Fleet API when request to product versions endpoint throws ECONNREFUSED (#172850)](#172850) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kyle Pollich","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-07T18:14:35Z","message":"[Fleet] Fix 500 in Fleet API when request to product versions endpoint throws ECONNREFUSED (#172850)\n\n## Summary\r\n\r\nNetwork-level errors will cause `fetch` to `throw` rather than resolving\r\nwith a status code. This PR updates our logic to handle this case for\r\nairgapped environments where `ECONNREFUSED` style errors squash HTTP\r\nrequests at the DNS level.","sha":"be6fbc4dcc8fff7e7419cf3fa9b05a6b13e3edba","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","backport:prev-minor","v8.12.0","v8.13.0","v8.11.3"],"number":172850,"url":"https://github.com/elastic/kibana/pull/172850","mergeCommit":{"message":"[Fleet] Fix 500 in Fleet API when request to product versions endpoint throws ECONNREFUSED (#172850)\n\n## Summary\r\n\r\nNetwork-level errors will cause `fetch` to `throw` rather than resolving\r\nwith a status code. This PR updates our logic to handle this case for\r\nairgapped environments where `ECONNREFUSED` style errors squash HTTP\r\nrequests at the DNS level.","sha":"be6fbc4dcc8fff7e7419cf3fa9b05a6b13e3edba"}},"sourceBranch":"main","suggestedTargetBranches":["8.12","8.11"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172850","number":172850,"mergeCommit":{"message":"[Fleet] Fix 500 in Fleet API when request to product versions endpoint throws ECONNREFUSED (#172850)\n\n## Summary\r\n\r\nNetwork-level errors will cause `fetch` to `throw` rather than resolving\r\nwith a status code. This PR updates our logic to handle this case for\r\nairgapped environments where `ECONNREFUSED` style errors squash HTTP\r\nrequests at the DNS level.","sha":"be6fbc4dcc8fff7e7419cf3fa9b05a6b13e3edba"}},{"branch":"8.11","label":"v8.11.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kyle Pollich <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 7, 2023
…endpoint throws ECONNREFUSED (#172850) (#172864) # Backport This will backport the following commits from `main` to `8.11`: - [[Fleet] Fix 500 in Fleet API when request to product versions endpoint throws ECONNREFUSED (#172850)](#172850) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kyle Pollich","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-07T18:14:35Z","message":"[Fleet] Fix 500 in Fleet API when request to product versions endpoint throws ECONNREFUSED (#172850)\n\n## Summary\r\n\r\nNetwork-level errors will cause `fetch` to `throw` rather than resolving\r\nwith a status code. This PR updates our logic to handle this case for\r\nairgapped environments where `ECONNREFUSED` style errors squash HTTP\r\nrequests at the DNS level.","sha":"be6fbc4dcc8fff7e7419cf3fa9b05a6b13e3edba","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","backport:prev-minor","v8.12.0","v8.13.0","v8.11.3"],"number":172850,"url":"https://github.com/elastic/kibana/pull/172850","mergeCommit":{"message":"[Fleet] Fix 500 in Fleet API when request to product versions endpoint throws ECONNREFUSED (#172850)\n\n## Summary\r\n\r\nNetwork-level errors will cause `fetch` to `throw` rather than resolving\r\nwith a status code. This PR updates our logic to handle this case for\r\nairgapped environments where `ECONNREFUSED` style errors squash HTTP\r\nrequests at the DNS level.","sha":"be6fbc4dcc8fff7e7419cf3fa9b05a6b13e3edba"}},"sourceBranch":"main","suggestedTargetBranches":["8.12","8.11"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172850","number":172850,"mergeCommit":{"message":"[Fleet] Fix 500 in Fleet API when request to product versions endpoint throws ECONNREFUSED (#172850)\n\n## Summary\r\n\r\nNetwork-level errors will cause `fetch` to `throw` rather than resolving\r\nwith a status code. This PR updates our logic to handle this case for\r\nairgapped environments where `ECONNREFUSED` style errors squash HTTP\r\nrequests at the DNS level.","sha":"be6fbc4dcc8fff7e7419cf3fa9b05a6b13e3edba"}},{"branch":"8.11","label":"v8.11.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kyle Pollich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Network-level errors will cause
fetchtothrowrather than resolving with a status code. This PR updates our logic to handle this case for airgapped environments whereECONNREFUSEDstyle errors squash HTTP requests at the DNS level.