Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.12] Add fieldsForAAD to observability plugin rule types (#172809) #172826

Merged
merged 1 commit into from
Dec 7, 2023
Merged

[8.12] Add fieldsForAAD to observability plugin rule types (#172809) #172826

merged 1 commit into from
Dec 7, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.12:

Questions ?

Please refer to the Backport tool documentation

@maryam-saeidi
Add fieldsForAAD to observability plugin rule types (elastic#172809)
faaec96 
Related to elastic#158324

## Summary

This PR adds `fieldsForAAD` to the SLO burn rate and Custom threshold
rules to ensure conditional actions can use fields related to these
rules.

<img
src="https://github.com/elastic/kibana/assets/12370520/7cb31448-58cc-4bf6-b0da-cdc5e746ae60"
width=500 />

(cherry picked from commit 6e69fdc)
@kibanamachine kibanamachine enabled auto-merge (squash) December 7, 2023 14:35
@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Dec 7, 2023
@kibanamachine kibanamachine mentioned this pull request Dec 7, 2023
Merged
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #36 / endpoint Response Actions Responder from the Endpoint list and details should show Responder from the endpoint details

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

@kibanamachine kibanamachine merged commit 555876a into elastic:8.12 Dec 7, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@maryam-saeidi maryam-saeidi

Labels
backport Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kibanamachine @elasticmachine @kibana-ci @maryam-saeidi