Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.12] Deprecate feature flag for Custom threshold rule (#172584) #172792

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.12:

Questions ?

Please refer to the Backport tool documentation

Resolves elastic#171406

- Deprecates following feature flag used for enabling/disabling Custom
threshold rule:
```
xpack.observability.unsafe.thresholdRule.enabled
```
- Removes usage of this flag from code.
- Adding this flag in `kibana.yml` will generate following warning:
```
[WARN ][config.deprecation] You no longer need to configure "xpack.observability.unsafe.thresholdRule.enabled".
```

---------

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 16f09fd)
@kibanamachine kibanamachine enabled auto-merge (squash) December 7, 2023 09:41
@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Dec 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kibanamachine kibanamachine merged commit d875875 into elastic:8.12 Dec 7, 2023
42 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 102.6KB 102.6KB -32.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @benakansara

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants