Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] Fix o11y view in app #172740

Merged
merged 1 commit into from
Dec 7, 2023
Merged

[RAM] Fix o11y view in app #172740

merged 1 commit into from
Dec 7, 2023

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Dec 6, 2023 •
edited by kibanamachine
Loading

Summary

Fix -> #166982

@XavierM XavierM added bug Fixes for quality problems that affect the customer experience high release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0 v8.11.2 labels Dec 6, 2023
@XavierM XavierM requested a review from a team as a code owner December 6, 2023 22:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Dec 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@XavierM XavierM force-pushed the fix-o11y-view-in-app branch from 87ed471 to c0c01d3 Compare December 6, 2023 22:19
ymao1
ymao1 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit ba27a25 into elastic:main Dec 7, 2023
36 checks passed
@ymao1 ymao1 mentioned this pull request Dec 7, 2023
Open
@kibanamachine kibanamachine mentioned this pull request Dec 7, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 7, 2023
@XavierM
[RAM] Fix o11y view in app (elastic#172740)
0f72cf8 
## Summary

Fix -> elastic#166982

(cherry picked from commit ba27a25)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 8.11 Backport failed because of merge conflicts
✅ 8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 172740

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 7, 2023
@kibanamachine @XavierM
[8.12] [RAM] Fix o11y view in app (#172740) (#172823)
1806937 
# Backport

This will backport the following commits from `main` to `8.12`:
- [[RAM] Fix o11y view in app
(#172740)](#172740)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Xavier
Mouligneau","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-07T14:00:49Z","message":"[RAM]
Fix o11y view in app (#172740)\n\n## Summary\r\n\r\nFix ->
https://github.com/elastic/kibana/issues/166982","sha":"ba27a25ec78a8e9b2afa63add5b48d07e33ac9bb","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","high","release_note:skip","Team:ResponseOps","v8.12.0","Team:obs-ux-management","v8.11.2","v8.13.0"],"number":172740,"url":"https://github.com/elastic/kibana/pull/172740","mergeCommit":{"message":"[RAM]
Fix o11y view in app (#172740)\n\n## Summary\r\n\r\nFix ->
https://github.com/elastic/kibana/issues/166982","sha":"ba27a25ec78a8e9b2afa63add5b48d07e33ac9bb"}},"sourceBranch":"main","suggestedTargetBranches":["8.12","8.11"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.11","label":"v8.11.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172740","number":172740,"mergeCommit":{"message":"[RAM]
Fix o11y view in app (#172740)\n\n## Summary\r\n\r\nFix ->
https://github.com/elastic/kibana/issues/166982","sha":"ba27a25ec78a8e9b2afa63add5b48d07e33ac9bb"}}]}]
BACKPORT-->

Co-authored-by: Xavier Mouligneau <[email protected]>
@XavierM XavierM removed the v8.11.2 label Dec 7, 2023
@XavierM
Copy link
Contributor Author

XavierM commented Dec 7, 2023

No need of a backport in 8.11.2. We are good the way, it is!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benakansara benakansara benakansara approved these changes

@ymao1 ymao1 ymao1 approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience high release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0 v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@XavierM @elasticmachine @kibana-ci @kibanamachine @ymao1 @benakansara