Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps] Fix for flaky test - Actions migrations "before all" hook for "7.10.0 migrates the casesConfiguration to be the incidentConfiguration in config, then 7.11.0 removes incidentConfiguration" #172733

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

doakalexi
Copy link
Contributor

@doakalexi doakalexi commented Dec 6, 2023

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@doakalexi doakalexi changed the title Removes skip on flaky test Fix for flaky test - Actions migrations "before all" hook for "7.10.0 migrates the casesConfiguration to be the incidentConfiguration in config, then 7.11.0 removes incidentConfiguration" Dec 7, 2023
@doakalexi doakalexi changed the title Fix for flaky test - Actions migrations "before all" hook for "7.10.0 migrates the casesConfiguration to be the incidentConfiguration in config, then 7.11.0 removes incidentConfiguration" [ResponseOps] Fix for flaky test - Actions migrations "before all" hook for "7.10.0 migrates the casesConfiguration to be the incidentConfiguration in config, then 7.11.0 removes incidentConfiguration" Dec 7, 2023
@doakalexi doakalexi added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) release_note:skip Skip the PR/issue when compiling release notes v8.12.0 v8.13.0 labels Dec 7, 2023
@doakalexi doakalexi marked this pull request as ready for review December 7, 2023 02:05
@doakalexi doakalexi requested a review from a team as a code owner December 7, 2023 02:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@doakalexi doakalexi added v8.12.0 and removed v8.12.0 labels Dec 7, 2023
@ymao1
Copy link
Contributor

ymao1 commented Dec 7, 2023

This original error looks like an ES connection timeout error and there were other tests in the same suite failing with the same error message so I'm 👍 to unskipping

https://buildkite.com/elastic/kibana-on-merge/builds/37902#018babde-636d-4a92-aa2e-10cdf75c6222

@doakalexi doakalexi merged commit 08386bf into elastic:main Dec 7, 2023
46 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 7, 2023
…ok for "7.10.0 migrates the casesConfiguration to be the incidentConfiguration in config, then 7.11.0 removes incidentConfiguration" (elastic#172733)

Resolves elastic#169159

## Summary

I only removed the skip bc the flaky test runner passed after 500+ runs.

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4231
x 50

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4232
x 250

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4234
x 250

(cherry picked from commit 08386bf)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 7, 2023
…all" hook for "7.10.0 migrates the casesConfiguration to be the incidentConfiguration in config, then 7.11.0 removes incidentConfiguration" (#172733) (#172835)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[ResponseOps] Fix for flaky test - Actions migrations "before all"
hook for "7.10.0 migrates the casesConfiguration to be the
incidentConfiguration in config, then 7.11.0 removes
incidentConfiguration"
(#172733)](#172733)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexi
Doak","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-07T15:10:42Z","message":"[ResponseOps]
Fix for flaky test - Actions migrations \"before all\" hook for \"7.10.0
migrates the casesConfiguration to be the incidentConfiguration in
config, then 7.11.0 removes incidentConfiguration\"
(#172733)\n\nResolves
https://github.com/elastic/kibana/issues/169159\r\n\r\n##
Summary\r\n\r\nI only removed the skip bc the flaky test runner passed
after 500+
runs.\r\n\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4231\r\nx
50\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4232\r\nx
250\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4234\r\nx
250","sha":"08386bf35ee1575ac37eb0c374c0f9752bef8ea5","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v8.12.0","v8.13.0"],"number":172733,"url":"https://github.com/elastic/kibana/pull/172733","mergeCommit":{"message":"[ResponseOps]
Fix for flaky test - Actions migrations \"before all\" hook for \"7.10.0
migrates the casesConfiguration to be the incidentConfiguration in
config, then 7.11.0 removes incidentConfiguration\"
(#172733)\n\nResolves
https://github.com/elastic/kibana/issues/169159\r\n\r\n##
Summary\r\n\r\nI only removed the skip bc the flaky test runner passed
after 500+
runs.\r\n\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4231\r\nx
50\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4232\r\nx
250\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4234\r\nx
250","sha":"08386bf35ee1575ac37eb0c374c0f9752bef8ea5"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172733","number":172733,"mergeCommit":{"message":"[ResponseOps]
Fix for flaky test - Actions migrations \"before all\" hook for \"7.10.0
migrates the casesConfiguration to be the incidentConfiguration in
config, then 7.11.0 removes incidentConfiguration\"
(#172733)\n\nResolves
https://github.com/elastic/kibana/issues/169159\r\n\r\n##
Summary\r\n\r\nI only removed the skip bc the flaky test runner passed
after 500+
runs.\r\n\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4231\r\nx
50\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4232\r\nx
250\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4234\r\nx
250","sha":"08386bf35ee1575ac37eb0c374c0f9752bef8ea5"}}]}] BACKPORT-->

Co-authored-by: Alexi Doak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0 v8.13.0
Projects
None yet
5 participants