-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Backport fixes for updating secrets to 8.11 #172730
Merged
juliaElastic
merged 3 commits into
elastic:8.11
from
kpollich:fleet/secrets-updates-backports
Dec 7, 2023
Merged
[Fleet] Backport fixes for updating secrets to 8.11 #172730
juliaElastic
merged 3 commits into
elastic:8.11
from
kpollich:fleet/secrets-updates-backports
Dec 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes elastic#172061 Fix for update agent policy with optional secret. Steps to verify: - change a secret variable in a package to optional, used `universal_profiling_agent` package ``` - name: profiler.secret_token title: Authorization description: Token used to authenticate the agent. required: false show_user: true type: text secret: true ``` - build a new package version and upload zip to fleet api locally - add integration policy by keeping the secret_token empty - edit the integration policy, and verify that the edit works - there is no secret value saved in `.fleet-secrets` <img width="1190" alt="image" src="https://github.com/elastic/kibana/assets/90178898/fd8e7a0d-199d-4dd3-bf2b-b887f48848a3"> - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
## Summary Relates elastic#172673 Fix remaining issue with update integration policy with optional secret: elastic#172673 (comment) Make sure to test with a 8.11+ fleet-server so that secret storage is enabled.
kpollich
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
v8.11.3
labels
Dec 6, 2023
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kpollich
changed the title
Fleet/secrets updates backports
[Fleet] Backport fixes for updating secrets to 8.11
Dec 6, 2023
@elasticmachine merge upstream |
juliaElastic
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating the backport!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
v8.11.3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backports the following PR's to 8.11
cc @juliaElastic