Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Backport fixes for updating secrets to 8.11 #172730

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

kpollich
Copy link
Member

@kpollich kpollich commented Dec 6, 2023

Closes elastic#172061

Fix for update agent policy with optional secret.

Steps to verify:
- change a secret variable in a package to optional, used
`universal_profiling_agent` package
```
          - name: profiler.secret_token
            title: Authorization
            description: Token used to authenticate the agent.
            required: false
            show_user: true
            type: text
            secret: true
```
- build a new package version and upload zip to fleet api locally
- add integration policy by keeping the secret_token empty
- edit the integration policy, and verify that the edit works
- there is no secret value saved in `.fleet-secrets`

<img width="1190" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/fd8e7a0d-199d-4dd3-bf2b-b887f48848a3">

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
## Summary

Relates elastic#172673

Fix remaining issue with update integration policy with optional secret:
elastic#172673 (comment)

Make sure to test with a 8.11+ fleet-server so that secret storage is
enabled.
@kpollich kpollich added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.11.3 labels Dec 6, 2023
@kpollich kpollich requested a review from juliaElastic December 6, 2023 20:14
@kpollich kpollich self-assigned this Dec 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kpollich kpollich changed the title Fleet/secrets updates backports [Fleet] Backport fixes for updating secrets to 8.11 Dec 6, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented Dec 6, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich
Copy link
Member Author

kpollich commented Dec 6, 2023

@elasticmachine merge upstream

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the backport!

@juliaElastic juliaElastic merged commit d77cacc into elastic:8.11 Dec 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.11.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants