[Discover] Fix time zone for field popover histogram and remove getTimeZone duplicates #172705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jughosta
added
release_note:skip
jughosta
commented
Dec 6, 2023
There was a problem hiding this comment.
Reused this implementation
jughosta
changed the title
jughosta
changed the title
jughosta
changed the title
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
stratoula
approved these changes
Dec 7, 2023
qn895
approved these changes
Dec 7, 2023
|
LGTM 🎉 |
davismcphee
approved these changes
Dec 8, 2023
| }); | ||
|
|
||
| afterAll(() => { | ||
| moment.tz.setDefault(originalTimezone ? originalTimezone.name : ''); |
There was a problem hiding this comment.
Nit: It doesn't look like originalTimezone is ever set.
| }); | ||
|
|
||
| it('returns timezone defined on uiSettings', () => { | ||
| const timezone = 'America/Toronto'; |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @jughosta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates a new package
@kbn/visualization-utilsand movesgetTimeZonehelper into it. Also the PR removes duplicates of other similar helpers.And the histogram in the field popover has now the same time zone configuration as the the main hits histogram:
For testing
Change
dateFormat:tzin Advanced Settings and check if histograms are rendered accordingly.