Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emergency Release - Revert "[Fleet] Fix get file handler for bundled package (#172182)" #172638

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Emergency Release - Revert "[Fleet] Fix get file handler for bundled package (#172182)" #172638

merged 1 commit into from
Dec 5, 2023

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Dec 5, 2023

This reverts commit 4d52ad2.

@kobelb kobelb added release_note:skip Skip the PR/issue when compiling release notes ci:project-deploy-observability Create an Observability project labels Dec 5, 2023
@kobelb kobelb requested a review from a team as a code owner December 5, 2023 21:22
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 5, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

nchaulet
nchaulet approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kibana-ci
Copy link
Collaborator

kibana-ci commented Dec 5, 2023 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5661 +5661
total size - 5.9MB +5.9MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kobelb kobelb merged commit 182cd19 into elastic:deploy-fix@1701687168 Dec 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

@nchaulet nchaulet nchaulet approved these changes

Assignees
No one assigned
Labels
ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kobelb @elasticmachine @kibana-ci @nchaulet @kpollich