Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Fix flaky sync_colors.tsx test #172633

Merged
merged 2 commits into from
Dec 6, 2023
Merged

[Dashboard] Fix flaky sync_colors.tsx test #172633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
601ac47
Add `retry` around `goToTimeRange` to reduce flakiness
Heenawter Dec 5, 2023
03e3499
Remove `.only`
Heenawter Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/functional/page_objects/time_picker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export class TimePickerPageObject extends FtrService {
});
if (isVisible) {
await this.testSubjects.click('noDataPopoverDismissButton');
await this.testSubjects.waitForDeleted('noDataPopoverDismissButton');
}
}

Expand Down
14 changes: 8 additions & 6 deletions x-pack/test/functional/page_objects/lens_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,14 @@ export function LensPageProvider({ getService, getPageObjects }: FtrProviderCont
* a range that has data in our dataset.
*/
async goToTimeRange(fromTime?: string, toTime?: string) {
await PageObjects.timePicker.ensureHiddenNoDataPopover();
fromTime = fromTime || PageObjects.timePicker.defaultStartTime;
toTime = toTime || PageObjects.timePicker.defaultEndTime;
await PageObjects.timePicker.setAbsoluteRange(fromTime, toTime);
// give some time for the update button tooltip to close
await PageObjects.common.sleep(500);
const from = fromTime || PageObjects.timePicker.defaultStartTime;
const to = toTime || PageObjects.timePicker.defaultEndTime;
await retry.try(async () => {
await PageObjects.timePicker.ensureHiddenNoDataPopover();
await PageObjects.timePicker.setAbsoluteRange(from, to);
// give some time for the update button tooltip to close
await PageObjects.common.sleep(500);
});
},

/**
Expand Down
Loading