Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Connectors][Case Management] Edit labels, automate screenshots #172610

Merged
merged 17 commits into from
Jan 26, 2024
Merged

[Connectors][Case Management] Edit labels, automate screenshots #172610

merged 17 commits into from
Jan 26, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 5, 2023 •
edited by kibanamachine
Loading

Summary

This PR:

  • Updates the Webhook - Case Management connector UI so that the "required" and "optional" qualifiers are subdued and separated from the field labels.
  • Automates screenshots to use in https://www.elastic.co/guide/en/kibana/master/cases-webhook-action-type.html instead of the animated gifs
  • Sorts the list of configuration options alphabetically in the Webhook - Case Management connector documentation.
  • Adds details about this connector in the openAPI specification.

Preview

https://kibana_172610.docs-preview.app.elstc.co/guide/en/kibana/master/cases-webhook-action-type.html

@lcawl lcawl added WIP Work in progress release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework v8.12.1 labels Dec 5, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Documentation preview:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl removed the WIP Work in progress label Dec 22, 2023
@lcawl lcawl marked this pull request as ready for review December 22, 2023 17:21
@lcawl lcawl requested a review from a team as a code owner December 22, 2023 17:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@cnasikas
Copy link
Member

@elasticmachine merge upstream

@lcawl lcawl marked this pull request as draft January 22, 2024 23:40
@lcawl lcawl added v8.13.0 and removed backport:skip This commit does not require backporting labels Jan 23, 2024
@lcawl lcawl marked this pull request as ready for review January 23, 2024 15:38
@cnasikas cnasikas disabled auto-merge January 25, 2024 13:23
@lcawl lcawl enabled auto-merge (squash) January 26, 2024 21:11
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackConnectors 520.5KB 520.7KB +182.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit bf40a0d into elastic:main Jan 26, 2024
18 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 26, 2024
@lcawl
[Connectors][Case Management] Edit labels, automate screenshots (elas…
036550d 
…tic#172610)

(cherry picked from commit bf40a0d)
@kibanamachine kibanamachine mentioned this pull request Jan 26, 2024
Closed
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 31, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

3 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine mentioned this pull request Feb 13, 2024
Merged
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@lcawl @CoenWarmer
[Connectors][Case Management] Edit labels, automate screenshots (elas…
c0d0a34 
…tic#172610)
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 172610 locally

4 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 172610 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 172610 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 172610 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 172610 locally

@jbudz jbudz added the backport:skip This commit does not require backporting label Sep 30, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.1 v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lcawl @apmmachine @elasticmachine @cnasikas @kibana-ci @kibanamachine @jbudz