Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Endpoint] Set perPage to 1000 for package policies query in Endpoint Artifacts form #172563

Merged
merged 2 commits into from
Dec 5, 2023
Merged

[Security Solution][Endpoint] Set perPage to 1000 for package policies query in Endpoint Artifacts form #172563

merged 2 commits into from
Dec 5, 2023

Conversation

dasansol92
Copy link
Contributor

@dasansol92 dasansol92 commented Dec 5, 2023 •
edited
Loading

Summary

It sets the perPage value to 1000 (overrides the default one set to 20) in order to display more policies in Artifacts form and also in the policy filter for artifacts list.

For maintainers

@dasansol92 dasansol92 added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.12.0 labels Dec 5, 2023
@dasansol92 dasansol92 marked this pull request as ready for review December 5, 2023 12:29
@dasansol92 dasansol92 requested a review from a team as a code owner December 5, 2023 12:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@dasansol92 dasansol92 mentioned this pull request Dec 5, 2023
Closed
2 tasks
paul-tavares
paul-tavares reviewed Dec 5, 2023
View reviewed changes
...ins/security_solution/public/management/components/artifact_list_page/artifact_list_page.tsx
@@ -163,6 +163,7 @@ export const ArtifactListPage = memo<ArtifactListPageProps>(
});

const policiesRequest = useGetEndpointSpecificPolicies({
perPage: 1000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one suggestion: add a test (unit) to this page component thta validates that we call the API with a perPage value of 1000

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: f21d08b

paul-tavares
paul-tavares approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test. 👍

@dasansol92 dasansol92 enabled auto-merge (squash) December 5, 2023 16:17
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.8MB 12.8MB +12.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dasansol92 dasansol92 merged commit 4abbe84 into elastic:main Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-tavares paul-tavares paul-tavares approved these changes

@kevinlog kevinlog kevinlog approved these changes

@joeypoon joeypoon joeypoon approved these changes

@tomsonpl tomsonpl Awaiting requested review from tomsonpl tomsonpl was automatically assigned from elastic/security-defend-workflows

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dasansol92 @elasticmachine @kibana-ci @joeypoon @kevinlog @paul-tavares