[Lens] Fixes the transition to a dashboard when originatingApp is not given #172543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
added
Feature:Lens
release_note:skip
stratoula
commented
Dec 5, 2023
| const path = | ||
| getOriginatingPath?.(dashboardId) ?? | ||
| (dashboardId === 'new' ? '#/create' : `#/view/${dashboardId}`); | ||
| const appId = originatingApp || 'dashboards'; |
There was a problem hiding this comment.
This is the fix. It was originatingApp ?? 'dashboards' causing the problematic redirect
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #172410
This is a regression caused by #167019.
The originatingApp on the navigateToPrefilledEditor defaults to "" (empty string) and not undefined.
Checklist