-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Fixes data drift numeric fields not showing correctly #172504
[ML] Fixes data drift numeric fields not showing correctly #172504
Conversation
Pinging @elastic/ml-ui (:ml) |
4c91218
to
057df9e
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: cc @qn895 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested and confirmed I am now seeing all the expected numeric fields.
) ## Summary This PR fixes an issue with data drift not showing numeric fields correctly for datasets that automatically uses random sampling. <img width="1720" alt="image" src="https://github.com/elastic/kibana/assets/43350163/65e5efce-e428-40fc-8b53-c373c5771dd0"> (cherry picked from commit b692493)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
) (#172591) # Backport This will backport the following commits from `main` to `8.11`: - [[ML] Fix data drift numeric fields not showing correctly (#172504)](#172504) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Quynh Nguyen (Quinn)","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-05T15:35:06Z","message":"[ML] Fix data drift numeric fields not showing correctly (#172504)\n\n## Summary\r\n\r\nThis PR fixes an issue with data drift not showing numeric fields\r\ncorrectly for datasets that automatically uses random sampling.\r\n\r\n<img width=\"1720\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/43350163/65e5efce-e428-40fc-8b53-c373c5771dd0\">","sha":"b692493c6f152308e44a99d5404fd9c166690729","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v8.12.0","v8.11.2"],"number":172504,"url":"https://github.com/elastic/kibana/pull/172504","mergeCommit":{"message":"[ML] Fix data drift numeric fields not showing correctly (#172504)\n\n## Summary\r\n\r\nThis PR fixes an issue with data drift not showing numeric fields\r\ncorrectly for datasets that automatically uses random sampling.\r\n\r\n<img width=\"1720\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/43350163/65e5efce-e428-40fc-8b53-c373c5771dd0\">","sha":"b692493c6f152308e44a99d5404fd9c166690729"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172504","number":172504,"mergeCommit":{"message":"[ML] Fix data drift numeric fields not showing correctly (#172504)\n\n## Summary\r\n\r\nThis PR fixes an issue with data drift not showing numeric fields\r\ncorrectly for datasets that automatically uses random sampling.\r\n\r\n<img width=\"1720\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/43350163/65e5efce-e428-40fc-8b53-c373c5771dd0\">","sha":"b692493c6f152308e44a99d5404fd9c166690729"}},{"branch":"8.11","label":"v8.11.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Quynh Nguyen (Quinn) <[email protected]>
This PR didn't make it on time for the latest 8.11.2 BC. Updating the labels. |
Summary
This PR fixes an issue with data drift not showing numeric fields correctly for datasets that automatically uses random sampling.