Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fixes data drift numeric fields not showing correctly #172504

Merged

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Dec 4, 2023

Summary

This PR fixes an issue with data drift not showing numeric fields correctly for datasets that automatically uses random sampling.

image

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895 qn895 force-pushed the ml-fix-data-drift-numeric-fields-not-showing branch from 4c91218 to 057df9e Compare December 4, 2023 17:50
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #10 / endpoint Response Actions Responder from alerts should show Responder from alert details under alerts list page

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 614.6KB 614.8KB +122.0B
securitySolution 12.9MB 12.9MB +6.4KB
securitySolutionServerless 331.5KB 337.7KB +6.3KB
total +12.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolutionServerless 41.7KB 41.7KB -1.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested and confirmed I am now seeing all the expected numeric fields.

@qn895 qn895 merged commit b692493 into elastic:main Dec 5, 2023
36 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 5, 2023
)

## Summary

This PR fixes an issue with data drift not showing numeric fields
correctly for datasets that automatically uses random sampling.

<img width="1720" alt="image"
src="https://github.com/elastic/kibana/assets/43350163/65e5efce-e428-40fc-8b53-c373c5771dd0">

(cherry picked from commit b692493)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 5, 2023
) (#172591)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[ML] Fix data drift numeric fields not showing correctly
(#172504)](#172504)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Quynh Nguyen
(Quinn)","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-05T15:35:06Z","message":"[ML]
Fix data drift numeric fields not showing correctly (#172504)\n\n##
Summary\r\n\r\nThis PR fixes an issue with data drift not showing
numeric fields\r\ncorrectly for datasets that automatically uses random
sampling.\r\n\r\n<img width=\"1720\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/43350163/65e5efce-e428-40fc-8b53-c373c5771dd0\">","sha":"b692493c6f152308e44a99d5404fd9c166690729","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v8.12.0","v8.11.2"],"number":172504,"url":"https://github.com/elastic/kibana/pull/172504","mergeCommit":{"message":"[ML]
Fix data drift numeric fields not showing correctly (#172504)\n\n##
Summary\r\n\r\nThis PR fixes an issue with data drift not showing
numeric fields\r\ncorrectly for datasets that automatically uses random
sampling.\r\n\r\n<img width=\"1720\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/43350163/65e5efce-e428-40fc-8b53-c373c5771dd0\">","sha":"b692493c6f152308e44a99d5404fd9c166690729"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172504","number":172504,"mergeCommit":{"message":"[ML]
Fix data drift numeric fields not showing correctly (#172504)\n\n##
Summary\r\n\r\nThis PR fixes an issue with data drift not showing
numeric fields\r\ncorrectly for datasets that automatically uses random
sampling.\r\n\r\n<img width=\"1720\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/43350163/65e5efce-e428-40fc-8b53-c373c5771dd0\">","sha":"b692493c6f152308e44a99d5404fd9c166690729"}},{"branch":"8.11","label":"v8.11.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Quynh Nguyen (Quinn) <[email protected]>
@mistic
Copy link
Member

mistic commented Dec 7, 2023

This PR didn't make it on time for the latest 8.11.2 BC. Updating the labels.

@mistic mistic added v8.11.3 and removed v8.11.2 labels Dec 7, 2023
@szabosteve szabosteve changed the title [ML] Fix data drift numeric fields not showing correctly [ML] Fixes data drift numeric fields not showing correctly Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants