[BUG][OBS-UX-MNGMT] Alert details page search bar doesn't consider QueryConfig in the Kibana Advanced setting #172498
Conversation
fkanout
added
bug
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @fkanout |
There was a problem hiding this comment.
@fkanout Following up the discussion on a similar issue that has been fixed with this PR, I confirm that your provided solution is correct and fixes the problem with the leading wildcard queries.
| @@ -41,6 +43,7 @@ export function ObservabilityAlertSearchBar({ | |||
| status, | |||
| }: ObservabilityAlertSearchBarProps) { | |||
| const toasts = useToasts(); | |||
| const { uiSettings } = useKibana().services; | |||
There was a problem hiding this comment.
@fkanout We should not use the useKibana here directly but rather provide the related services via services prop to ensure this dependency is clear for the consumers. (That was the reason that this component didn't have useKibana so far)
For more information about why we need to pass dependency like this, you can check this presentation.
Would you please create a PR to fix this issue?
cc @mgiota
There was a problem hiding this comment.
@maryam-saeidi Very good point, you are right we have services passed, so we can get uiSettings from there. Nice presentation!
Refactors according to this [comment](#172498 (comment)) --------- Co-authored-by: Kibana Machine <[email protected]>
Summary
It fixes #172495 by considering the Query related config in the Kbiana advanced settings.
Before
After