Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM Dashboard] Replace FID with INP #172467

Merged
merged 18 commits into from
Dec 5, 2023
Merged

[RUM Dashboard] Replace FID with INP #172467

merged 18 commits into from
Dec 5, 2023

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Dec 4, 2023

Summary

Fixes #172005
Fixes #172006
Fixes #172007

Use numeric_labels.inp_value for field name.

Replace FID with INP

image

Omit page-exit from APM view

image

In Exploratory view

image

Release note

To support the new Interaction to Next Paint (INP) metric that will replace First Input Delay (FID) in Google's Core Web Vitals we are updating the "User Experience" app within Observability to display the new INP metric. Capturing the INP metric requires running version 5.16.0 or newer of our RUM JS agent.

We will continue to capture the FID metric and it will continue to be available in custom dashboards and Lens.

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 marked this pull request as ready for review December 4, 2023 16:51
@shahzad31 shahzad31 requested review from a team as code owners December 4, 2023 16:51
@shahzad31 shahzad31 added the release_note:skip Skip the PR/issue when compiling release notes label Dec 4, 2023
@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:obs-ux-management Observability Management User Experience Team Team:uptime labels Dec 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FID is still available in exploratory view. How do I get to the INP metric, and should FID now be excluded?
image

Curious about this: the value of INP here is considered needs improvement, but still displays at red
image

Also, don't think this is part of the PR but notice how the number and the percentage sign have a space between.

@dominiqueclarke
Copy link
Contributor

image
INP is missing from the Observability overview widget

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code looks good and I tested this by loading the UX data from the e2e tests and verifying the feature appears and works as I expect.

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM testing with the mock data.

I am curious to know what's the status of the agent change, as I'm nervous about merging this with the agent changes pending, and being able to only test against mock data.

I'll let you coordinate those questions though. Otherwise, this LGTM.

@shahzad31 shahzad31 enabled auto-merge (squash) December 5, 2023 19:08
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ux 171 173 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 600 590 -10
observabilityShared 302 303 +1
total -9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
exploratoryView 203.5KB 203.7KB +218.0B
observability 1.1MB 1.1MB +860.0B
ux 168.9KB 170.6KB +1.8KB
total +2.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
exploratoryView 44.3KB 44.6KB +348.0B
ux 6.8KB 6.8KB +67.0B
total +415.0B
Unknown metric groups

API count

id before after diff
observability 609 599 -10
observabilityShared 306 307 +1
total -9

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 9695939 into elastic:main Dec 5, 2023
42 checks passed
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Dec 5, 2023
@shahzad31 shahzad31 deleted the inp branch June 6, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:obs-ux-management Observability Management User Experience Team v8.12.0
Projects
None yet
8 participants