-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RUM Dashboard] Replace FID with INP #172467
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Pinging @elastic/apm-ui (Team:APM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FID is still available in exploratory view. How do I get to the INP metric, and should FID now be excluded?
Curious about this: the value of INP here is considered needs improvement, but still displays at red
Also, don't think this is part of the PR but notice how the number and the percentage sign have a space between.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - code looks good and I tested this by loading the UX data from the e2e tests and verifying the feature appears and works as I expect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM testing with the mock data.
I am curious to know what's the status of the agent change, as I'm nervous about merging this with the agent changes pending, and being able to only test against mock data.
I'll let you coordinate those questions though. Otherwise, this LGTM.
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
Summary
Fixes #172005
Fixes #172006
Fixes #172007
Use
numeric_labels.inp_value
for field name.Replace FID with INP
Omit
page-exit
from APM viewIn Exploratory view
Release note
To support the new Interaction to Next Paint (INP) metric that will replace First Input Delay (FID) in Google's Core Web Vitals we are updating the "User Experience" app within Observability to display the new INP metric. Capturing the INP metric requires running version 5.16.0 or newer of our RUM JS agent.
We will continue to capture the FID metric and it will continue to be available in custom dashboards and Lens.