Backport puppeteer update to Kibana 7.17 #172440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eokoneyo
added
backport
Team:SharedUX
eokoneyo
added
the
(Deprecated) Feature:Reporting
eokoneyo
force-pushed
the
backport-puppeteer-21.5.2
branch
2 times, most recently
from
2132652 to
631cd0b
Compare
eokoneyo
force-pushed
the
backport-puppeteer-21.5.2
branch
3 times, most recently
from
bf26769 to
9a6fe09
Compare
eokoneyo
force-pushed
the
backport-puppeteer-21.5.2
branch
2 times, most recently
from
258a7e3 to
84513e6
Compare
eokoneyo
force-pushed
the
backport-puppeteer-21.5.2
branch
from
1c273bc to
481158e
Compare
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
tsullivan
requested changes
Dec 7, 2023
Comment on lines
+95
to
+96
| "globby/fast-glob": "^3.2.11", | ||
| "wrap-ansi": "7.0.0" |
There was a problem hiding this comment.
The changes here may have been unintentionally backported.
Suggested change
| "globby/fast-glob": "^3.2.11", | |
| "wrap-ansi": "7.0.0" | |
| "globby/fast-glob": "^3.2.11" |
There was a problem hiding this comment.
I talked offline with you and found this is an intentional change. Disregard my comment!
There was a problem hiding this comment.
For context, the resolution for wrap-ansi was added to circumvent failing build where the ESM version of the package was being required. See here
x-pack/build_chromium/build_util.py
Outdated
| @@ -20,10 +20,10 @@ def mkdir(dir): | |||
| if not os.path.exists(dir): | |||
| return os.makedirs(dir) | |||
|
|
|||
| def md5_file(filename): | |||
| def sha256_file(filename): | |||
| """Builds a hex md5 hash of the given file""" | |||
There was a problem hiding this comment.
Suggested change
| """Builds a hex md5 hash of the given file""" | |
| """Builds a hex sha1 hash of the given file""" |
There was a problem hiding this comment.
thanks for the catch!
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @eokoneyo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a manual back port of #172332 to Kibana 7.17. It's worth pointing out in this PR, for validating archive and binary checksums we now use the sha256 hashing algorithm.