Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLO][8.11] Add date_formats to SLI ingest pipeline template #172377

Merged
merged 1 commit into from
Dec 1, 2023
Merged

[SLO][8.11] Add date_formats to SLI ingest pipeline template #172377

merged 1 commit into from
Dec 1, 2023

Conversation

simianhacker
Copy link
Member

Summary

This PR fixes #172372 by adding the date_formats attribute to the date_index_name pipeline step for the SLI ingest pipeline that every SLO runs through. This PR is only for 8.11, the fix for main will be included with: #172224

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@simianhacker simianhacker added Team:obs-ux-management Observability Management User Experience Team v8.11.2 release_note:fix labels Dec 1, 2023
@simianhacker simianhacker changed the title [SLO][8.110 Add date_formats to SLI ingest pipeline template [SLO][8.11] Add date_formats to SLI ingest pipeline template Dec 1, 2023
kdelemme
kdelemme approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@simianhacker simianhacker marked this pull request as ready for review December 1, 2023 17:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@simianhacker simianhacker merged commit f698bed into elastic:8.11 Dec 1, 2023
20 checks passed
@simianhacker simianhacker mentioned this pull request Dec 4, 2023
Closed
@simianhacker simianhacker deleted the issue-172372-add-date-formats-to-sli-ingest-pipeline branch April 17, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdelemme kdelemme kdelemme approved these changes

Assignees
No one assigned
Labels
Feature:SLO release_note:fix Team:obs-ux-management Observability Management User Experience Team v8.11.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@simianhacker @apmmachine @elasticmachine @kibana-ci @kdelemme