Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Unskip remaining tests that no longer fail after #172220 #172307

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

davismcphee
Copy link
Contributor

Summary

This PR unskips the remaining skipped tests that no longer fail after the fix to ES|QL time_zone param in #172220.

Resolves #172247.
Resolves #172246.
Resolves #172248.

Checklist

For maintainers

@davismcphee davismcphee added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.12.0 labels Nov 30, 2023
@davismcphee davismcphee self-assigned this Nov 30, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #3 / Timelines saves timeline as new should save timelines as new should save timelines as new

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @davismcphee

@davismcphee davismcphee marked this pull request as ready for review November 30, 2023 18:23
@davismcphee davismcphee requested a review from a team as a code owner November 30, 2023 18:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davismcphee davismcphee merged commit f98f282 into elastic:main Nov 30, 2023
39 checks passed
@davismcphee davismcphee deleted the unskip-tests-esql-time-zone branch November 30, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.12.0
Projects
None yet
4 participants