Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution]{Detection Engine] unskip ES|QL tests #172279

Merged
merged 2 commits into from
Dec 1, 2023
Merged

[Security Solution]{Detection Engine] unskip ES|QL tests #172279

merged 2 commits into from
Dec 1, 2023

Conversation

vitaliidm
Copy link
Contributor

Tests were skipped in #172260 due to errors related to ES API changes elastic/elasticsearch#102767

Errors originated in DIscover component and have been fixed in #172220

@vitaliidm vitaliidm marked this pull request as ready for review November 30, 2023 13:06
@vitaliidm vitaliidm requested a review from a team as a code owner November 30, 2023 13:06
@vitaliidm vitaliidm requested a review from yctercero November 30, 2023 13:06
@vitaliidm vitaliidm self-assigned this Nov 30, 2023
@vitaliidm vitaliidm added the release_note:skip Skip the PR/issue when compiling release notes label Nov 30, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #68 / cloud_security_posture Cloud Posture Dashboard Page Kubernetes Dashboard displays accurate summary compliance score
  • [job] [logs] FTR Configs #4 / security APIs - Session Concurrent Limit Session Concurrent Limit cleanup should properly clean up sessions that exceeded concurrent session limit even for multiple providers

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm

yctercero
yctercero approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@vitaliidm vitaliidm merged commit f59ac29 into elastic:main Dec 1, 2023
2 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 1, 2023
@vitaliidm vitaliidm deleted the unskip-esql-tests branch March 4, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yctercero yctercero yctercero approved these changes

Assignees

@vitaliidm vitaliidm

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vitaliidm @kibana-ci @yctercero @kibanamachine