[Connectors][ServiceNow ITOM] Edit required labels and automate screenshots #172229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
added
release_note:skip
|
Documentation preview: |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
lcawl
added
v8.12.1
backport:prev-minor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
lcawl
changed the title
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 4, 2023
…nshots (elastic#172229) (cherry picked from commit e69063e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
lcawl
added a commit
that referenced
this pull request
Dec 4, 2023
…e screenshots (#172229) (#172516) # Backport This will backport the following commits from `main` to `8.11`: - [[Connectors][ServiceNow ITOM] Edit required labels and automate screenshots (#172229)](#172229) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-04T19:50:07Z","message":"[Connectors][ServiceNow ITOM] Edit required labels and automate screenshots (#172229)","sha":"e69063e08256b315175af9f749de762197537ca3","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","docs","Feature:Actions/ConnectorTypes","backport:prev-minor","v8.12.0","v8.12.1"],"number":172229,"url":"https://github.com/elastic/kibana/pull/172229","mergeCommit":{"message":"[Connectors][ServiceNow ITOM] Edit required labels and automate screenshots (#172229)","sha":"e69063e08256b315175af9f749de762197537ca3"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172229","number":172229,"mergeCommit":{"message":"[Connectors][ServiceNow ITOM] Edit required labels and automate screenshots (#172229)","sha":"e69063e08256b315175af9f749de762197537ca3"}},{"branch":"8.12","label":"v8.12.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
NOTE: It seems like some connector UIs callout the "Required" fields while others callout the "Optional" fields. IMO we should follow the same strategy across all the connector UIs, so that users have consistent experience. However, I've not made that change in this PR.