[8.11] [Fleet] Support integration secrets with required: false (#172078)
#172201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…72078) ## Summary Support secrets with `required: false` in package manifests. Closes elastic#172061 ## To test 1. Set up an integration in a local package registry with a variable that has `secret: true` and `required: false`, e.g. ```yml - name: secret_token type: password title: (Test) Secret Token description: | Test non-required secret show_user: true secret: true required: false ``` 2. Create a package policy for your test package and note the optional secret is rendered properly 3. Submit the policy editor form without filling out a value for the optional secret 4. Observe the request is successful 5. Edit the package policy and set a value for the optional secret 6. Observe that the secret creation logic works as expected ## Screen recording https://github.com/elastic/kibana/assets/6766512/36e271c5-29d0-49f8-91e8-abc6a7871b20 (cherry picked from commit e64f475)
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
@elasticmachine merge upstream |
nchaulet
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.11:required: false(#172078)Questions ?
Please refer to the Backport tool documentation