Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Migration to new ES|QL grammar #172148

Closed

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Nov 29, 2023

Summary

This PR aligns the (new) Kibana grammar to the newer ES grammar changes proposed in elastic/elasticsearch#100740 .

EXPAND and INLINESTATS has been reinstated here (even when not used) to exactly match the ES grammar.

Most of the changes are due to TOKEN renaming plus few other changes on how identifiers are now parsed.

Revisit the validation logic helped also to find a couple of bugs on our validation side, but they were very minimal and limited.

Checklist

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:ES|QL ES|QL related features in Kibana labels Nov 29, 2023
@dej611 dej611 changed the base branch from main to feature/esql-validation November 29, 2023 11:36
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 2.3MB 2.3MB -26.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 added release_note:skip Skip the PR/issue when compiling release notes v8.13.0 labels Dec 7, 2023
@dej611 dej611 deleted the branch elastic:feature/esql-validation December 7, 2023 09:23
@dej611 dej611 closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants