-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] Migration to new ES|QL grammar #172148
Closed
dej611
wants to merge
12
commits into
elastic:feature/esql-validation
from
dej611:fix/esql-new-grammar
Closed
[ES|QL] Migration to new ES|QL grammar #172148
dej611
wants to merge
12
commits into
elastic:feature/esql-validation
from
dej611:fix/esql-new-grammar
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dej611
added
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
Feature:ES|QL
ES|QL related features in Kibana
labels
Nov 29, 2023
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
dej611
added
release_note:skip
Skip the PR/issue when compiling release notes
v8.13.0
labels
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:ES|QL
ES|QL related features in Kibana
release_note:skip
Skip the PR/issue when compiling release notes
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v8.13.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aligns the (new) Kibana grammar to the newer ES grammar changes proposed in elastic/elasticsearch#100740 .
EXPAND
andINLINESTATS
has been reinstated here (even when not used) to exactly match the ES grammar.Most of the changes are due to
TOKEN
renaming plus few other changes on how identifiers are now parsed.Revisit the validation logic helped also to find a couple of bugs on our validation side, but they were very minimal and limited.
Checklist