Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixes kibana object list in new job from recognised index page #171935

Merged
merged 1 commit into from
Nov 30, 2023
Merged

[ML] Fixes kibana object list in new job from recognised index page #171935

merged 1 commit into from
Nov 30, 2023

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Nov 24, 2023 •
edited
Loading

Fixes issue where the list of kibana objects in a module are not being rendered correctly.
The issue was caused by the kibana objects from the module not being initially added to the list.

Before
image

After
image

@jgowdyelastic jgowdyelastic marked this pull request as ready for review November 24, 2023 17:09
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner November 24, 2023 17:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #3 / Correlation tab should update timeline after removing eql should update timeline after removing eql

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.6MB 3.6MB +23.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

darnautov
darnautov approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit a484572 into elastic:main Nov 30, 2023
9 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 30, 2023
@szabosteve szabosteve changed the title [ML] Fixing kibana object list in new job from recognised index page [ML] Fixes kibana object list in new job from recognised index page Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@darnautov darnautov darnautov approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
backport:skip This commit does not require backporting Feature:Anomaly Detection ML anomaly detection :ml release_note:fix v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgowdyelastic @elasticmachine @kibana-ci @darnautov @peteharverson @kibanamachine