Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EDR Workflows] Disabled Timeout input for saved queries preloaded queries #171931

Merged
merged 1 commit into from
Nov 30, 2023
Merged

[EDR Workflows] Disabled Timeout input for saved queries preloaded queries #171931

merged 1 commit into from
Nov 30, 2023

Conversation

szwarckonrad
Copy link
Contributor

#171906

Render timeout field on saved queries view, for preloaded queries as disabled.

Screenshot 2023-11-24 at 12 06 17

@szwarckonrad szwarckonrad added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Osquery v8.12.0 labels Nov 24, 2023
@szwarckonrad szwarckonrad self-assigned this Nov 24, 2023
@szwarckonrad szwarckonrad requested a review from a team as a code owner November 24, 2023 15:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
osquery 1.0MB 1.0MB +13.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @szwarckonrad

patrykkopycinski
patrykkopycinski approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙇

@szwarckonrad szwarckonrad merged commit 71eca5b into elastic:main Nov 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsonpl tomsonpl tomsonpl approved these changes

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

Assignees

@szwarckonrad szwarckonrad

Labels
backport:skip This commit does not require backporting Osquery release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@szwarckonrad @elasticmachine @kibana-ci @patrykkopycinski @tomsonpl