Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom threshold] Fix threshold change when unit is percent (pct) #171857

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

maryam-saeidi
Copy link
Member

Partially implements #171121

Summary

This PR fixes the threshold change when the field unit is percent (pct).

Screen.Recording.2023-11-23.at.11.59.35.mov

@maryam-saeidi maryam-saeidi added the release_note:skip Skip the PR/issue when compiling release notes label Nov 23, 2023
@maryam-saeidi maryam-saeidi self-assigned this Nov 23, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@maryam-saeidi maryam-saeidi marked this pull request as ready for review November 23, 2023 14:20
@maryam-saeidi maryam-saeidi requested a review from a team as a code owner November 23, 2023 14:20
@maryam-saeidi maryam-saeidi added the Team:obs-ux-management Observability Management User Experience Team label Nov 23, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@maryam-saeidi maryam-saeidi added the Feature: Custom threshold Observability custom threshold rule type label Nov 23, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 511 512 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.1MB 1.1MB +488.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

Copy link
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maryam-saeidi maryam-saeidi merged commit 553bcde into elastic:main Nov 24, 2023
4 checks passed
@maryam-saeidi maryam-saeidi deleted the 171121-custom-threshold-pct branch November 24, 2023 08:36
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature: Custom threshold Observability custom threshold rule type release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants