Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OAS] Add support for links and custom_details in PagerDuty connector #171812

Merged
merged 2 commits into from
Nov 24, 2023
Merged

[OAS] Add support for links and custom_details in PagerDuty connector #171812

merged 2 commits into from
Nov 24, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 23, 2023

Summary

Relates to #170044

This PR updates the openAPI specification for the run connector API to include details specific to PagerDuty connectors. The data types and descriptions are derived from https://github.com/elastic/kibana/blob/main/x-pack/plugins/stack_connectors/README.md#pagerduty

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework v8.12.0 labels Nov 23, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl marked this pull request as ready for review November 23, 2023 15:57
@lcawl lcawl requested a review from a team as a code owner November 23, 2023 15:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@lcawl lcawl requested a review from cnasikas November 23, 2023 15:57
@lcawl lcawl merged commit 1a2363d into elastic:main Nov 24, 2023
@lcawl lcawl deleted the run-pagerduty-connector branch November 24, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcawl @apmmachine @kibana-ci @elasticmachine @cnasikas