[8.11] Remove CI Composite Storybook (#171258) #171695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Closes elastic#160803 This PR removes the `CI Composite` story because it has been broken since at least ac23dce (and possibly since b862a6c). The functionality is covered by the generated `index.html` in https://github.com/elastic/kibana/blob/dda4498fee84708143ce4671af880db785f9e652/.buildkite/scripts/steps/storybooks/build_and_upload.ts#L105-L120 To fix the composite story requires generating `stories.json` for every storybook, which requires migrating the repo off the deprecated `storiesOf` API. That task is quite extensive and would be better handled alongside an upgrade to Storybook 7.x (cherry picked from commit 1919c87)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @Ikuni17 |
jsanz
referenced
this pull request
in jsanz/kibana
Nov 28, 2023
# Backport Manual backport due to merge conflicts. This will backport the following commits from `main` to `7.17`: - [Remove CI Composite Storybook (elastic#171258)](elastic#171258) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Brad White","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-21T21:59:39Z","message":"Remove CI Composite Storybook (elastic#171258)\n\n## Summary\r\nCloses elastic#160803\r\n\r\nThis PR removes the `CI Composite` story because it has been broken\r\nsince at least ac23dce (and possibly\r\nsince b862a6c). The functionality is\r\ncovered by the generated `index.html` in\r\nhttps://github.com/elastic/kibana/blob/dda4498fee84708143ce4671af880db785f9e652/.buildkite/scripts/steps/storybooks/build_and_upload.ts#L105-L120\r\n\r\nTo fix the composite story requires generating `stories.json` for every\r\nstorybook, which requires migrating the repo off the deprecated\r\n`storiesOf` API. That task is quite extensive and would be better\r\nhandled alongside an upgrade to Storybook 7.x","sha":"1919c87b90c4f489c2027d71293631d89034f40f","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","ci:build-storybooks","v8.12.0"],"number":171258,"url":"https://github.com/elastic/kibana/pull/171258","mergeCommit":{"message":"Remove CI Composite Storybook (elastic#171258)\n\n## Summary\r\nCloses elastic#160803\r\n\r\nThis PR removes the `CI Composite` story because it has been broken\r\nsince at least ac23dce (and possibly\r\nsince b862a6c). The functionality is\r\ncovered by the generated `index.html` in\r\nhttps://github.com/elastic/kibana/blob/dda4498fee84708143ce4671af880db785f9e652/.buildkite/scripts/steps/storybooks/build_and_upload.ts#L105-L120\r\n\r\nTo fix the composite story requires generating `stories.json` for every\r\nstorybook, which requires migrating the repo off the deprecated\r\n`storiesOf` API. That task is quite extensive and would be better\r\nhandled alongside an upgrade to Storybook 7.x","sha":"1919c87b90c4f489c2027d71293631d89034f40f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171258","number":171258,"mergeCommit":{"message":"Remove CI Composite Storybook (elastic#171258)\n\n## Summary\r\nCloses elastic#160803\r\n\r\nThis PR removes the `CI Composite` story because it has been broken\r\nsince at least ac23dce (and possibly\r\nsince b862a6c). The functionality is\r\ncovered by the generated `index.html` in\r\nhttps://github.com/elastic/kibana/blob/dda4498fee84708143ce4671af880db785f9e652/.buildkite/scripts/steps/storybooks/build_and_upload.ts#L105-L120\r\n\r\nTo fix the composite story requires generating `stories.json` for every\r\nstorybook, which requires migrating the repo off the deprecated\r\n`storiesOf` API. That task is quite extensive and would be better\r\nhandled alongside an upgrade to Storybook 7.x","sha":"1919c87b90c4f489c2027d71293631d89034f40f"}},{"url":"https://github.com/elastic/kibana/pull/171695","number":171695,"branch":"8.11","state":"OPEN"}]}] BACKPORT--> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.11:Questions ?
Please refer to the Backport tool documentation