[Docs][Maps] Include details about the headers requested and served by EMS #171659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview: |
jsanz
added
release_note:skip
nreese
reviewed
Nov 22, 2023
nreese
reviewed
Nov 22, 2023
nreese
reviewed
Nov 22, 2023
nreese
reviewed
Nov 22, 2023
nreese
reviewed
Nov 22, 2023
nreese
reviewed
Nov 22, 2023
nreese
reviewed
Nov 22, 2023
nreese
reviewed
Nov 22, 2023
I'm not fully sure because the curl requests only contain some basic request headers as opposed to the listed ones in the I'll do the change in a separate commit so it is easy to revert if we prefer the other way. |
|
@amyjtechwriter, can you look at the texts on these changes when you have some time? |
amyjtechwriter
approved these changes
Nov 28, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 28, 2023
…y EMS (elastic#171659) Fixes elastic#129751 ## Summary Extends the EMS documentation to detail request and response headers the browser sends to EMS resources and includes also a minimal `curl` command to request the response headers for same resource as well. I tried to edit this in a way it does not take the whole page but happy to hear feedback or ideas on how to make this easier to digest. https://github.com/elastic/kibana/assets/188264/27e83a5f-4d01-47a8-af2c-3739576bf56e Also, I am not sure if this is something worth adding to our release notes 🤔 (cherry picked from commit 0a7299b)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jsanz
added a commit
to jsanz/kibana
that referenced
this pull request
Nov 28, 2023
…y EMS (elastic#171659) Fixes elastic#129751 ## Summary Extends the EMS documentation to detail request and response headers the browser sends to EMS resources and includes also a minimal `curl` command to request the response headers for same resource as well. I tried to edit this in a way it does not take the whole page but happy to hear feedback or ideas on how to make this easier to digest. https://github.com/elastic/kibana/assets/188264/27e83a5f-4d01-47a8-af2c-3739576bf56e Also, I am not sure if this is something worth adding to our release notes 🤔 (cherry picked from commit 0a7299b) # Conflicts: # docs/maps/connect-to-ems.asciidoc
kibanamachine
added a commit
that referenced
this pull request
Nov 28, 2023
…erved by EMS (#171659) (#172090) # Backport This will backport the following commits from `main` to `8.11`: - [[Docs][Maps] Include details about the headers requested and served by EMS (#171659)](#171659) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jorge Sanz","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-28T16:59:28Z","message":"[Docs][Maps] Include details about the headers requested and served by EMS (#171659)\n\nFixes #129751\r\n\r\n## Summary\r\n\r\nExtends the EMS documentation to detail request and response headers the\r\nbrowser sends to EMS resources and includes also a minimal `curl`\r\ncommand to request the response headers for same resource as well.\r\n\r\nI tried to edit this in a way it does not take the whole page but happy\r\nto hear feedback or ideas on how to make this easier to digest.\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/188264/27e83a5f-4d01-47a8-af2c-3739576bf56e\r\n\r\n\r\nAlso, I am not sure if this is something worth adding to our release\r\nnotes :thinking:","sha":"0a7299b0ac2aadfe47aa374002636341a032a6ed","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","docs","backport:all-open","v8.12.0"],"number":171659,"url":"https://github.com/elastic/kibana/pull/171659","mergeCommit":{"message":"[Docs][Maps] Include details about the headers requested and served by EMS (#171659)\n\nFixes #129751\r\n\r\n## Summary\r\n\r\nExtends the EMS documentation to detail request and response headers the\r\nbrowser sends to EMS resources and includes also a minimal `curl`\r\ncommand to request the response headers for same resource as well.\r\n\r\nI tried to edit this in a way it does not take the whole page but happy\r\nto hear feedback or ideas on how to make this easier to digest.\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/188264/27e83a5f-4d01-47a8-af2c-3739576bf56e\r\n\r\n\r\nAlso, I am not sure if this is something worth adding to our release\r\nnotes :thinking:","sha":"0a7299b0ac2aadfe47aa374002636341a032a6ed"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171659","number":171659,"mergeCommit":{"message":"[Docs][Maps] Include details about the headers requested and served by EMS (#171659)\n\nFixes #129751\r\n\r\n## Summary\r\n\r\nExtends the EMS documentation to detail request and response headers the\r\nbrowser sends to EMS resources and includes also a minimal `curl`\r\ncommand to request the response headers for same resource as well.\r\n\r\nI tried to edit this in a way it does not take the whole page but happy\r\nto hear feedback or ideas on how to make this easier to digest.\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/188264/27e83a5f-4d01-47a8-af2c-3739576bf56e\r\n\r\n\r\nAlso, I am not sure if this is something worth adding to our release\r\nnotes :thinking:","sha":"0a7299b0ac2aadfe47aa374002636341a032a6ed"}}]}] BACKPORT--> Co-authored-by: Jorge Sanz <[email protected]>
jsanz
added a commit
that referenced
this pull request
Nov 29, 2023
…erved by EMS (#171659) (#172092) # Backport This will backport the following commits from `main` to `7.17`: - [[Docs][Maps] Include details about the headers requested and served by EMS (#171659)](#171659) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jorge Sanz","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-28T16:59:28Z","message":"[Docs][Maps] Include details about the headers requested and served by EMS (#171659)\n\nFixes #129751\r\n\r\n## Summary\r\n\r\nExtends the EMS documentation to detail request and response headers the\r\nbrowser sends to EMS resources and includes also a minimal `curl`\r\ncommand to request the response headers for same resource as well.\r\n\r\nI tried to edit this in a way it does not take the whole page but happy\r\nto hear feedback or ideas on how to make this easier to digest.\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/188264/27e83a5f-4d01-47a8-af2c-3739576bf56e\r\n\r\n\r\nAlso, I am not sure if this is something worth adding to our release\r\nnotes :thinking:","sha":"0a7299b0ac2aadfe47aa374002636341a032a6ed","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","docs","backport:all-open","v8.12.0"],"number":171659,"url":"https://github.com/elastic/kibana/pull/171659","mergeCommit":{"message":"[Docs][Maps] Include details about the headers requested and served by EMS (#171659)\n\nFixes #129751\r\n\r\n## Summary\r\n\r\nExtends the EMS documentation to detail request and response headers the\r\nbrowser sends to EMS resources and includes also a minimal `curl`\r\ncommand to request the response headers for same resource as well.\r\n\r\nI tried to edit this in a way it does not take the whole page but happy\r\nto hear feedback or ideas on how to make this easier to digest.\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/188264/27e83a5f-4d01-47a8-af2c-3739576bf56e\r\n\r\n\r\nAlso, I am not sure if this is something worth adding to our release\r\nnotes :thinking:","sha":"0a7299b0ac2aadfe47aa374002636341a032a6ed"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171659","number":171659,"mergeCommit":{"message":"[Docs][Maps] Include details about the headers requested and served by EMS (#171659)\n\nFixes #129751\r\n\r\n## Summary\r\n\r\nExtends the EMS documentation to detail request and response headers the\r\nbrowser sends to EMS resources and includes also a minimal `curl`\r\ncommand to request the response headers for same resource as well.\r\n\r\nI tried to edit this in a way it does not take the whole page but happy\r\nto hear feedback or ideas on how to make this easier to digest.\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/188264/27e83a5f-4d01-47a8-af2c-3739576bf56e\r\n\r\n\r\nAlso, I am not sure if this is something worth adding to our release\r\nnotes :thinking:","sha":"0a7299b0ac2aadfe47aa374002636341a032a6ed"}},{"url":"https://github.com/elastic/kibana/pull/172090","number":172090,"branch":"8.11","state":"OPEN"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129751
Summary
Extends the EMS documentation to detail request and response headers the browser sends to EMS resources and includes also a minimal
curlcommand to request the response headers for same resource as well.I tried to edit this in a way it does not take the whole page but happy to hear feedback or ideas on how to make this easier to digest.
vokoscreenNG-2023-11-21_16-39-52.mp4
Also, I am not sure if this is something worth adding to our release notes 🤔